Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 2955293002: Add enable_dsyms=true option when building CronetChromeWebView framework. (Closed)

Created:
3 years, 5 months ago by Hiroshi Ichikawa
Modified:
3 years, 5 months ago
Reviewers:
michaeldo
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add enable_dsyms=true option when building CronetChromeWebView framework. Otherwise the script fails complaining that CronetChromeWebView.dSYM file is missing. Review-Url: https://codereview.chromium.org/2955293002 Cr-Commit-Position: refs/heads/master@{#483143} Committed: https://chromium.googlesource.com/chromium/src/+/5b511ec35f67276bb85cb2a6a0ed5f726aec89ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web_view/tools/build.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Hiroshi Ichikawa
3 years, 5 months ago (2017-06-28 06:14:53 UTC) #2
michaeldo
lgtm
3 years, 5 months ago (2017-06-28 20:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955293002/1
3 years, 5 months ago (2017-06-28 20:39:00 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 21:20:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b511ec35f67276bb85cb2a6a0ed...

Powered by Google App Engine
This is Rietveld 408576698