Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2964743002: Revert "Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames()" (Closed)

Created:
3 years, 5 months ago by jsbell
Modified:
3 years, 4 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, haraken, darin-cc_chromium.org, cmumford, mac-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, jsbell+idb_chromium.org, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames()" Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames() Deprecated in M58, now removing in M60 per the plan. Intent to Deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/2fUr-3wFPKI/discussion Intent to Remove: https://groups.google.com/a/chromium.org/d/topic/blink-dev/A6m1Pt9-BAo/discussion Chrome Status Entry: https://www.chromestatus.com/features/5725741740195840 BUG=696010 This reverts commit 7a400ee2cb54a4be1a7b4dc6a3d407693d3699a4. Use counter stats were misinterpreted and the numbers are not moving in the right direction. Revert the deprecation for M60 and push out the removal to M64.

Patch Set 1 #

Patch Set 2 : Undeprecate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -4 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/indexeddb/corrupted_open_db_detection.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-indexeddb-allowed-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-indexeddb.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/worker-for-indexeddb.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics-workers.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics-workers-expected.txt View 1 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/getdatabasenames-failed-open.html View 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/getdatabasenames-failed-open-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/resources/factory-basics.js View 1 chunk +88 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (9 generated)
jsbell
The CQ bit was checked by jsbell@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-30 23:50:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964743002/1
3 years, 5 months ago (2017-06-30 23:50:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-01 01:53:36 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/480696)
3 years, 5 months ago (2017-07-01 01:53:37 UTC) #4
jsbell
The CQ bit was checked by jsbell@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 19:18:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964743002/20001
3 years, 5 months ago (2017-07-06 19:19:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 22:38:33 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 5 months ago (2017-07-06 22:38:34 UTC) #8
jsbell
3 years, 4 months ago (2017-08-24 17:53:59 UTC) #9 
Description was changed from

==========
Revert "Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames()"

    Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames()

    Deprecated in M58, now removing in M60 per the plan.

    Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/2fUr-3wFPKI/discus...
    Intent to Remove:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/A6m1Pt9-BAo/discus...
    Chrome Status Entry: https://www.chromestatus.com/features/5725741740195840

    BUG=696010

This reverts commit 7a400ee2cb54a4be1a7b4dc6a3d407693d3699a4.

Use counter stats were misinterpreted and the numbers are not moving
in the right direction. Revert the deprecation for M60 and push out
the removal to M64.
==========

to

==========
Revert "Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames()"

    Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames()

    Deprecated in M58, now removing in M60 per the plan.

    Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/2fUr-3wFPKI/discus...
    Intent to Remove:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/A6m1Pt9-BAo/discus...
    Chrome Status Entry: https://www.chromestatus.com/features/5725741740195840

    BUG=696010

This reverts commit 7a400ee2cb54a4be1a7b4dc6a3d407693d3699a4.

Use counter stats were misinterpreted and the numbers are not moving
in the right direction. Revert the deprecation for M60 and push out
the removal to M64.
==========

Powered by Google App Engine
This is Rietveld 408576698