Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 3001233002: Handle labelled breaks (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -30 lines) Patch
M pkg/compiler/lib/src/js_model/locals.dart View 1 6 chunks +59 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 4 chunks +1 line, -3 lines 1 comment Download
M tests/language/language_dart2js.status View 12 chunks +2 lines, -14 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-18 19:24:37 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3001233002/diff/20001/tests/corelib_2/corelib_2.status File tests/corelib_2/corelib_2.status (left): https://codereview.chromium.org/3001233002/diff/20001/tests/corelib_2/corelib_2.status#oldcode486 tests/corelib_2/corelib_2.status:486: date_time_test: Skip # TODO(30492): TODO(redemption): Timeout \o/
3 years, 4 months ago (2017-08-18 21:22:01 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-19 08:10:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6b36ecefe70992ef93cc76430d9b85c26686346a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698