Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 3001963002: [dart:io] Namespaces for file IO (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 3 months ago
Reviewers:
CC:
reviews_dartlang.org, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] Namespaces for file IO WIP DO NOT SUBMIT

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 : Directories #

Patch Set 5 : Fix patch files #

Patch Set 6 : Platform specific stuff #

Patch Set 7 : Pipe down to File on Linux #

Patch Set 8 : Cleanup. Linux directory and process #

Patch Set 9 : Linux FileSystemWatcher #

Patch Set 10 : Some work on Android #

Patch Set 11 : Android fixes #

Patch Set 12 : Start on Fuchsia #

Patch Set 13 : Work on Fuchsia #

Patch Set 14 : Cleanup #

Patch Set 15 : Refactor Linux and Android #

Patch Set 16 : Fixes for Fuchsia #

Patch Set 17 : Merge #

Patch Set 18 : Simplify #

Patch Set 19 : Fix ResolvePath #

Patch Set 20 : Mac fixes #

Patch Set 21 : Windows #

Patch Set 22 : Command line arg for testing #

Patch Set 23 : Adds a test #

Patch Set 24 : Fuchsia fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3546 lines, -1700 lines) Patch
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 1 2 3 4 21 6 chunks +46 lines, -27 lines 0 comments Download
M runtime/bin/dartutils.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +17 lines, -2 lines 0 comments Download
M runtime/bin/directory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 10 chunks +32 lines, -14 lines 0 comments Download
M runtime/bin/directory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 8 chunks +182 lines, -138 lines 0 comments Download
M runtime/bin/directory_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 13 chunks +162 lines, -106 lines 0 comments Download
M runtime/bin/directory_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 10 chunks +243 lines, -132 lines 0 comments Download
M runtime/bin/directory_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 14 chunks +118 lines, -68 lines 0 comments Download
M runtime/bin/directory_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 6 chunks +11 lines, -23 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +13 lines, -9 lines 0 comments Download
M runtime/bin/directory_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +28 lines, -25 lines 0 comments Download
M runtime/bin/directory_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 7 chunks +12 lines, -29 lines 0 comments Download
M runtime/bin/file.h View 1 2 3 4 5 6 7 8 9 10 12 2 chunks +42 lines, -20 lines 0 comments Download
M runtime/bin/file.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 23 chunks +547 lines, -500 lines 0 comments Download
M runtime/bin/file_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 17 chunks +185 lines, -86 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 16 chunks +169 lines, -100 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 16 chunks +161 lines, -76 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 14 chunks +34 lines, -33 lines 0 comments Download
M runtime/bin/file_patch.dart View 1 2 3 4 5 6 7 8 3 chunks +27 lines, -17 lines 0 comments Download
M runtime/bin/file_system_entity_patch.dart View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M runtime/bin/file_system_watcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/file_system_watcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +10 lines, -7 lines 0 comments Download
M runtime/bin/file_system_watcher_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +7 lines, -1 line 0 comments Download
M runtime/bin/file_system_watcher_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/file_system_watcher_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/file_system_watcher_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file_test.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/file_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 18 chunks +24 lines, -23 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/io_impl_sources.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +44 lines, -41 lines 0 comments Download
M runtime/bin/io_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 11 chunks +29 lines, -7 lines 0 comments Download
A runtime/bin/namespace.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +98 lines, -0 lines 0 comments Download
A runtime/bin/namespace.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +143 lines, -0 lines 0 comments Download
A runtime/bin/namespace_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +101 lines, -0 lines 0 comments Download
A runtime/bin/namespace_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +101 lines, -0 lines 0 comments Download
A runtime/bin/namespace_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +101 lines, -0 lines 0 comments Download
A runtime/bin/namespace_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +64 lines, -0 lines 0 comments Download
A runtime/bin/namespace_patch.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +45 lines, -0 lines 0 comments Download
A runtime/bin/namespace_unsupported.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +40 lines, -0 lines 0 comments Download
A runtime/bin/namespace_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +65 lines, -0 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/platform_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/platform_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/platform_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M runtime/bin/process.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 10 chunks +22 lines, -20 lines 0 comments Download
M runtime/bin/process_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 11 chunks +26 lines, -13 lines 0 comments Download
M runtime/bin/process_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 8 chunks +20 lines, -9 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 10 chunks +56 lines, -14 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +3 lines, -1 line 0 comments Download
M runtime/bin/process_patch.dart View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/process_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/security_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/security_context_fuchsia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/security_context_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/snapshot_utils.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 2 3 4 21 6 chunks +46 lines, -27 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 14 chunks +40 lines, -27 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 18 chunks +62 lines, -41 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 2 9 chunks +17 lines, -15 lines 0 comments Download
M sdk/lib/io/io.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/io_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/link.dart View 1 6 chunks +12 lines, -9 lines 0 comments Download
A sdk/lib/io/namespace_impl.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +22 lines, -0 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +17 lines, -0 lines 0 comments Download
A tests/standalone/io/namespace_test.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +231 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (1 generated)
zra
3 years, 3 months ago (2017-08-31 02:41:12 UTC) #1
Description was changed from

==========
[dart:io] Namespaces for file IO

WIP DO NOT SUBMIT
==========

to

==========
[dart:io] Namespaces for file IO

WIP DO NOT SUBMIT
==========

Powered by Google App Engine
This is Rietveld 408576698