Skip flushes on icon writes for 10x better jumplist perf

chrome/browser/jumplist_win.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/jumplist_win.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
@@ skipping 64 matching lines @@
   // We don't have to care about the extension of this temporary file because
   // JumpList does not care about it.
   base::FilePath path;
   if (!base::CreateTemporaryFileInDir(icon_dir, &path))
     return false;
 
   // Create an icon file from the favicon attached to the given |page|, and
   // save it as the temporary file.
   gfx::ImageFamily image_family;
   image_family.Add(gfx::Image::CreateFrom1xBitmap(bitmap));
-  if (!IconUtil::CreateIconFileFromImageFamily(image_family, path))
+  if (!IconUtil::CreateIconFileFromImageFamily(image_family, path,
+                                               IconUtil::NORMAL_WRITE))

[Alexei Svitkine (slow), 2015/09/30 21:26:23]

Nit: {}'s

[brucedawson, 2015/09/30 22:13:59]

Style guide says that {}'s are optional on single-line statements, and line 79
omits them so I think they should be omitted for consistency.

     return false;
 
   // Add this icon file to the list and return its absolute path.
   // The IShellLink::SetIcon() function needs the absolute path to an icon.
   *icon_path = path;
   return true;
 }
 
 // Updates the "Tasks" category of the JumpList.
 bool UpdateTaskCategory(
@@ skipping 435 matching lines @@
 void JumpList::TopSitesLoaded(history::TopSites* top_sites) {
 }
 
 void JumpList::TopSitesChanged(history::TopSites* top_sites,
                                ChangeReason change_reason) {
   top_sites->GetMostVisitedURLs(
       base::Bind(&JumpList::OnMostVisitedURLsAvailable,
                  weak_ptr_factory_.GetWeakPtr()),
       false);
 }