Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4584)

Unified Diff: chrome/browser/jumplist_win.cc

Issue 1372303002: Skip flushes on icon writes for 10x better jumplist perf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make the change for jumplists only Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/icon_util.h » ('j') | ui/gfx/icon_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/jumplist_win.cc
diff --git a/chrome/browser/jumplist_win.cc b/chrome/browser/jumplist_win.cc
index ba78502d17eafa5540ab6590e9efcc81ac8ddc2e..9774bde361b6e40d63037926717df001e23ec830 100644
--- a/chrome/browser/jumplist_win.cc
+++ b/chrome/browser/jumplist_win.cc
@@ -82,7 +82,8 @@ bool CreateIconFile(const SkBitmap& bitmap,
// save it as the temporary file.
gfx::ImageFamily image_family;
image_family.Add(gfx::Image::CreateFrom1xBitmap(bitmap));
- if (!IconUtil::CreateIconFileFromImageFamily(image_family, path))
+ if (!IconUtil::CreateIconFileFromImageFamily(image_family, path,
+ IconUtil::NORMAL_WRITE))
Alexei Svitkine (slow) 2015/09/30 21:26:23 Nit: {}'s
brucedawson 2015/09/30 22:13:59 Style guide says that {}'s are optional on single-
return false;
// Add this icon file to the list and return its absolute path.
« no previous file with comments | « no previous file | ui/gfx/icon_util.h » ('j') | ui/gfx/icon_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698