Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2858933004: [turbofan] Lower monomorphic loads during graph building.

Created:
7 months, 1 week ago by Jarin
Modified:
5 months, 3 weeks ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower monomorphic loads during graph building. BUG=v8:6357

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Use property-access-builder #

Patch Set 4 : Prune headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -35 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 2 4 chunks +8 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 5 chunks +43 lines, -19 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/js-type-hint-lowering.h View 1 2 4 chunks +55 lines, -4 lines 0 comments Download
M src/compiler/js-type-hint-lowering.cc View 1 2 3 4 chunks +67 lines, -5 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (5 generated)
Jarin
5 months, 3 weeks ago (2017-06-19 11:52:32 UTC) #2
Could you take a look, please?

I am especially interested in your opinion on what to do with the
LoweringResult: 

- do you think all the js-type-hint-lowering methods use LoweringResult?

- I am not really happy about the structuring of work between
TryBuildSimplifiedLoadNamed and VisitLdaNamedProperty each do a bit of the
re-wiring work, but I kept it this way to be consistent with other early
lowerings. How would you feel about shifting the ApplyEarlyReduction work to
VisitLdaNamedProperty>

Powered by Google App Engine
This is Rietveld 0eb02b776