Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: chrome/browser/ui/android/tab_model/android_live_tab_context.cc

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)
Patch Set: Remove NOTREACHED(). Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/android_live_tab_context.cc
diff --git a/chrome/browser/ui/android/tab_model/android_live_tab_context.cc b/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
index 73740024ea894e4a9d2b34dda825fe2274f40e5f..37c849f28ad0f000135d443f45604f01726d1624 100644
--- a/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
+++ b/chrome/browser/ui/android/tab_model/android_live_tab_context.cc
@@ -32,8 +32,8 @@ int AndroidLiveTabContext::GetSelectedIndex() const {
return tab_model_->GetActiveIndex();
}
-// Not supported by android.
std::string AndroidLiveTabContext::GetAppName() const {
+ // Not applicable to android.
return std::string();
}
@@ -54,11 +54,26 @@ sessions::LiveTab* AndroidLiveTabContext::GetActiveLiveTab() const {
return sessions::ContentLiveTab::GetForWebContents(web_contents);
}
-// Not supported by android.
bool AndroidLiveTabContext::IsTabPinned(int index) const {
+ // Not applicable to android.
return false;
}
+const gfx::Rect AndroidLiveTabContext::GetRestoredBounds() const {
+ // Not applicable to android.
+ return gfx::Rect();
+}
+
+ui::WindowShowState AndroidLiveTabContext::GetRestoredState() const {
+ // Not applicable to android.
+ return ui::SHOW_STATE_NORMAL;
+}
+
+std::string AndroidLiveTabContext::GetWorkspace() const {
+ // Not applicable to android.
+ return std::string();
+}
+
sessions::LiveTab* AndroidLiveTabContext::AddRestoredTab(
const std::vector<sessions::SerializedNavigationEntry>& navigations,
int tab_index,
« no previous file with comments | « chrome/browser/ui/android/tab_model/android_live_tab_context.h ('k') | chrome/browser/ui/browser_live_tab_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698