Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4294)

Unified Diff: chrome/browser/ui/browser_live_tab_context.h

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)
Patch Set: Remove NOTREACHED(). Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_live_tab_context.h
diff --git a/chrome/browser/ui/browser_live_tab_context.h b/chrome/browser/ui/browser_live_tab_context.h
index c92b4e0d3a96c96becb986ecdfd9ba911b7d21bb..715f5b6096c9f106dfa6d2b1cd29f0b74e4a9522 100644
--- a/chrome/browser/ui/browser_live_tab_context.h
+++ b/chrome/browser/ui/browser_live_tab_context.h
@@ -11,6 +11,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "components/sessions/core/live_tab_context.h"
+#include "ui/base/ui_base_types.h"
class Browser;
class Profile;
@@ -19,6 +20,10 @@ namespace content {
class WebContents;
}
+namespace gfx {
+class Rect;
+}
+
// Implementation of LiveTabContext which uses an instance of
// Browser in order to fulfil its duties.
class BrowserLiveTabContext : public sessions::LiveTabContext {
@@ -35,6 +40,10 @@ class BrowserLiveTabContext : public sessions::LiveTabContext {
sessions::LiveTab* GetLiveTabAt(int index) const override;
sessions::LiveTab* GetActiveLiveTab() const override;
bool IsTabPinned(int index) const override;
+ const gfx::Rect GetRestoredBounds() const override;
+ ui::WindowShowState GetRestoredState() const override;
+ std::string GetWorkspace() const override;
+
sessions::LiveTab* AddRestoredTab(
const std::vector<sessions::SerializedNavigationEntry>& navigations,
int tab_index,
@@ -55,9 +64,11 @@ class BrowserLiveTabContext : public sessions::LiveTabContext {
void CloseTab() override;
// see Browser::Create
- static sessions::LiveTabContext* Create(
- Profile* profile,
- const std::string& app_name);
+ static sessions::LiveTabContext* Create(Profile* profile,
+ const std::string& app_name,
+ const gfx::Rect& bounds,
+ ui::WindowShowState show_state,
+ const std::string& workspace);
// see browser::FindBrowserForWebContents
static sessions::LiveTabContext* FindContextForWebContents(
« no previous file with comments | « chrome/browser/ui/android/tab_model/android_live_tab_context.cc ('k') | chrome/browser/ui/browser_live_tab_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698