ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h - Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)

Patch Set: Remove NOTREACHED(). Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sessions/core/tab_restore_service_helper.cc ('k') | ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h

diff --git a/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h b/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h

index 20a5a21aecb545ada2d8b5376701ae61c87a2e30..7f75480fc51a583d70dfe6d8d0d6cd7d05a3c49d 100644

--- a/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h

+++ b/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h

@@ -24,7 +24,10 @@ class IOSChromeTabRestoreServiceClient

private:

// TabRestoreServiceClient:

sessions::LiveTabContext* CreateLiveTabContext(

- const std::string& app_name) override;

+ const std::string& app_name,

+ const gfx::Rect& bounds,

+ ui::WindowShowState show_state,

+ const std::string& workspace) override;

sessions::LiveTabContext* FindLiveTabContextForTab(

const sessions::LiveTab* tab) override;

sessions::LiveTabContext* FindLiveTabContextWithID(