ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm - Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)

Patch Set: Remove NOTREACHED(). Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h ('k') | ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

diff --git a/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm b/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

index 43774af627da6323450b69470118a01c049305cc..a84e9d9402049da9925b5ba448e0bf4904dd9ee8 100644

--- a/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

+++ b/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

@@ -70,7 +70,10 @@ IOSChromeTabRestoreServiceClient::~IOSChromeTabRestoreServiceClient() {}

sessions::LiveTabContext*

IOSChromeTabRestoreServiceClient::CreateLiveTabContext(

- const std::string& app_name) {

+ const std::string& /* app_name */,

+ const gfx::Rect& /* bounds */,

+ ui::WindowShowState /* show_state */,

+ const std::string& /* workspace */) {

return TabRestoreServiceDelegateImplIOSFactory::GetForBrowserState(

browser_state_);

}