Split GetPermissionStatus into GetPermissionStatusForFrame/Worker

content/browser/background_sync/background_sync_manager.cc

Index: content/browser/background_sync/background_sync_manager.cc
diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc
index 43c905851e292dbc43f777eea723a71cfb2bdefd..7d01303da1ad460511fad776a52dbdc3401209b6 100644
--- a/content/browser/background_sync/background_sync_manager.cc
+++ b/content/browser/background_sync/background_sync_manager.cc
@@ -96,8 +96,8 @@ blink::mojom::PermissionStatus GetBackgroundSyncPermissionOnUIThread(
     return blink::mojom::PermissionStatus::DENIED;
 
   // The requesting origin always matches the embedding origin.
-  return permission_manager->GetPermissionStatus(
-      PermissionType::BACKGROUND_SYNC, origin, origin);
+  return permission_manager->GetPermissionStatusForWorker(

[johnme, 2017/06/12 10:18:20]

Is this correct? It seems that this codepath applies both to bgsync
registrations from frames and from service workers, so for example it'll
incorrectly return DENIED for requests from frames.

In general there are quite a few codepaths like this that can be reached both
via requests from frames and via requests from workers. Such codepaths are
merged to avoid code duplication. It's going to be awkward if they need to start
plumbing different argument types depending on the source of the request,
through all the layers. If that's really necessary, it might be useful to have a
PermissionRequestSource type in both content and Blink that can be initialised
with either a frame or worker.

Currently Feature Policy doesn't include
(https://wicg.github.io/feature-policy/#defined-features) any features that seem
relevant to workers/Service Workers (e.g. notifications). Is that deliberate, to
avoid the loophole where a restricted frame spawns a worker/SW that is
unrestricted? Or will Feature Policy eventually allow preventing
installing/spawning workers/SWs? If Feature Policy isn't planned to cover APIs
available in workers/SWs, perhaps we can just have a
GetPermissionStatusForAPIExposedInWorkers method that can be used in such merged
codepaths.

+      PermissionType::BACKGROUND_SYNC, origin);
 }
 
 void NotifyBackgroundSyncRegisteredOnUIThread(