|
Split GetPermissionStatus into GetPermissionStatusForFrame/Worker
Currently we only expose PermissionManager::GetPermissionStatus to content,
which returns the permission status for a given origin/embedding origin pair.
However, when a request is coming from a frame, the RenderFrameHost is needed
to do certain permission checks (e.g. checking the Feature Policy and checking
Android permissions, crbug.com/703498). In other cases, the request is coming
from a worker, which does not have a frame associated with it.
This CL splits GetPermissionStatus into GetPermissionStatusForFrame,
GetPermissionStatusForWorker. The former takes a RenderFrameHost as an argument
while the latter just takes an origin.
BUG= 703498
Total comments: 19
Total comments: 5
Total comments: 9
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+350 lines, -191 lines) |
Patch |
|
M |
android_webview/browser/aw_permission_manager.h
|
View
|
1
2
3
4
5
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
android_webview/browser/aw_permission_manager.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+15 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/budget_service/budget_service_impl.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+5 lines, -3 lines |
1 comment
|
Download
|
|
M |
chrome/browser/geolocation/geolocation_permission_context_unittest.cc
|
View
|
1
2
3
4
5
|
14 chunks |
+80 lines, -72 lines |
0 comments
|
Download
|
|
M |
chrome/browser/permissions/permission_manager.h
|
View
|
|
1 chunk |
+6 lines, -3 lines |
1 comment
|
Download
|
|
M |
chrome/browser/permissions/permission_manager.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+32 lines, -9 lines |
1 comment
|
Download
|
|
M |
chrome/browser/permissions/permission_manager_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
5 chunks |
+31 lines, -10 lines |
0 comments
|
Download
|
|
M |
chromecast/browser/cast_permission_manager.h
|
View
|
1
2
3
4
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
chromecast/browser/cast_permission_manager.cc
|
View
|
1
2
3
4
|
1 chunk |
+11 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/background_sync/background_sync_manager.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
1 comment
|
Download
|
|
M |
content/browser/background_sync/background_sync_manager_unittest.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
content/browser/background_sync/background_sync_service_impl_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/browser/permissions/permission_service_impl.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
|
M |
content/browser/permissions/permission_service_impl_unittest.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/public/browser/permission_manager.h
|
View
|
|
1 chunk |
+12 lines, -7 lines |
5 comments
|
Download
|
|
M |
content/shell/browser/layout_test/layout_test_notification_manager.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/shell/browser/layout_test/layout_test_permission_manager.h
|
View
|
|
2 chunks |
+12 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/shell/browser/layout_test/layout_test_permission_manager.cc
|
View
|
|
2 chunks |
+30 lines, -12 lines |
0 comments
|
Download
|
|
M |
content/shell/browser/layout_test/layout_test_push_messaging_service.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/shell/browser/layout_test/layout_test_push_messaging_service.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/shell/browser/shell_permission_manager.h
|
View
|
|
1 chunk |
+7 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/shell/browser/shell_permission_manager.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+28 lines, -16 lines |
0 comments
|
Download
|
|
M |
content/test/mock_permission_manager.h
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_permission_manager.h
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_permission_manager.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+12 lines, -3 lines |
0 comments
|
Download
|
|
M |
headless/lib/headless_browser_browsertest.cc
|
View
|
|
1 chunk |
+8 lines, -3 lines |
0 comments
|
Download
|
Total messages: 60 (38 generated)
|