Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: headless/lib/headless_browser_browsertest.cc

Issue 2908133003: Split GetPermissionStatus into GetPermissionStatusForFrame/Worker
Patch Set: Split GetPermissionStatus into GetPermissionStatusForFrame/Worker Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/headless_browser_browsertest.cc
diff --git a/headless/lib/headless_browser_browsertest.cc b/headless/lib/headless_browser_browsertest.cc
index 5ca4e666ee62734c0763a977450ee2a4b4d7f099..a4c4688d469d896e51d1dc2c86430c982edb2f55 100644
--- a/headless/lib/headless_browser_browsertest.cc
+++ b/headless/lib/headless_browser_browsertest.cc
@@ -777,10 +777,15 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, PermissionManagerAlwaysASK) {
web_contents->browser_context()->GetPermissionManager();
EXPECT_NE(nullptr, permission_manager);
- // Check that the permission manager returns ASK for a given permission type.
+ // Check that the permission manager returns ASK for a given permission type,
+ // and DENIED for a worker.
EXPECT_EQ(blink::mojom::PermissionStatus::ASK,
- permission_manager->GetPermissionStatus(
- content::PermissionType::NOTIFICATIONS, url, url));
+ permission_manager->GetPermissionStatusForFrame(
+ content::PermissionType::NOTIFICATIONS,
+ /*render_frame_host=*/nullptr, url));
+ EXPECT_EQ(blink::mojom::PermissionStatus::DENIED,
+ permission_manager->GetPermissionStatusForWorker(
+ content::PermissionType::NOTIFICATIONS, url));
}
class HeadlessBrowserTestWithNetLog : public HeadlessBrowserTest {

Powered by Google App Engine
This is Rietveld 408576698