Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(437)

Issue 2937503002: CSP, PlzNavigate: make clear what happens with unique origins. (Closed)

Created:
10 months, 2 weeks ago by arthursonzogni
Modified:
10 months, 1 week ago
Reviewers:
Mike West
CC:
andypaicu, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP, PlzNavigate: make clear what happens with unique origins. This CL makes the decision that when the current origin is unique, no url can match 'self'. That was already the case before this CL, but now it is explicitly stated. It removes several methods and merges several attributes of CSPContext. The goal is to make it less easy to shoot ourself in the foot. A few tests are added too. BUG=692449, 694959 Review-Url: https://codereview.chromium.org/2937503002 Cr-Commit-Position: refs/heads/master@{#480427} Committed: https://chromium.googlesource.com/chromium/src/+/6f31c861309594a5b9c2b1b92c74bfc26abe24fd

Patch Set 1 #

Patch Set 2 : Add web platform tests. #

Messages

Total messages: 27 (20 generated)
arthursonzogni
Hi Mike, Could you please review this? +CC andypaicu@ FYI
10 months, 2 weeks ago (2017-06-13 10:02:03 UTC) #11
Mike West
LGTM, if you add some layout tests in //third_party/WebKit/LayoutTests/external/wpt/content-security-policy/ to ensure that we're helping other ...
10 months, 2 weeks ago (2017-06-14 06:58:07 UTC) #12
arthursonzogni
On 2017/06/14 06:58:07, Mike West wrote: > LGTM, if you add some layout tests in ...
10 months, 2 weeks ago (2017-06-14 08:29:26 UTC) #13
arthursonzogni
Hi Mike, I added two new tests. Is it what you had in mind? Note: ...
10 months, 2 weeks ago (2017-06-14 15:38:02 UTC) #21
Mike West
lgtm
10 months, 1 week ago (2017-06-19 12:21:35 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937503002/100001
10 months, 1 week ago (2017-06-19 12:21:49 UTC) #24
commit-bot: I haz the power
10 months, 1 week ago (2017-06-19 14:01:59 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6f31c861309594a5b9c2b1b92c74...

Powered by Google App Engine
This is Rietveld 408576698