Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2941123002: [Telemetry] Move discover to common/py_utils (Closed)

Created:
3 years, 6 months ago by eakuefner
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add shim #

Patch Set 3 : fix imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -404 lines) Patch
A + common/py_utils/py_utils/discover.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + common/py_utils/py_utils/discover_unittest.py View 1 chunk +2 lines, -3 lines 0 comments Download
A + common/py_utils/py_utils/test_data/discoverable_classes/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + common/py_utils/py_utils/test_data/discoverable_classes/another_discover_dummyclass.py View 1 chunk +1 line, -1 line 0 comments Download
A + common/py_utils/py_utils/test_data/discoverable_classes/discover_dummyclass.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + common/py_utils/py_utils/test_data/discoverable_classes/parameter_discover_dummyclass.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/benchmark_runner.py View 1 2 2 chunks +1 line, -1 line 0 comments Download
D telemetry/telemetry/core/discover.py View 1 1 chunk +5 lines, -185 lines 0 comments Download
D telemetry/telemetry/core/discover_unittest.py View 1 chunk +0 lines, -147 lines 0 comments Download
M telemetry/telemetry/core/platform.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/profiler/profiler_finder.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/tracing_controller_backend.py View 1 chunk +1 line, -1 line 0 comments Download
D telemetry/telemetry/internal/testing/discoverable_classes/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D telemetry/telemetry/internal/testing/discoverable_classes/another_discover_dummyclass.py View 1 chunk +0 lines, -33 lines 0 comments Download
D telemetry/telemetry/internal/testing/discoverable_classes/discover_dummyclass.py View 1 chunk +0 lines, -9 lines 0 comments Download
D telemetry/telemetry/internal/testing/discoverable_classes/parameter_discover_dummyclass.py View 1 chunk +0 lines, -11 lines 0 comments Download
M telemetry/telemetry/record_wpr.py View 2 chunks +1 line, -1 line 0 comments Download
M telemetry/telemetry/testing/run_browser_tests.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/testing/story_set_smoke_test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/value/__init__.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
eakuefner
Ned, please take a look.
3 years, 6 months ago (2017-06-15 20:31:22 UTC) #2
nednguyen
On 2017/06/15 20:31:22, eakuefner wrote: > Ned, please take a look. discover is used in ...
3 years, 6 months ago (2017-06-15 20:32:35 UTC) #3
eakuefner
On 2017/06/15 at 20:32:35, nednguyen wrote: > On 2017/06/15 20:31:22, eakuefner wrote: > > Ned, ...
3 years, 6 months ago (2017-06-15 20:41:16 UTC) #4
nednguyen
lgtm
3 years, 6 months ago (2017-06-15 20:44:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941123002/20001
3 years, 6 months ago (2017-06-15 20:46:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941123002/20001
3 years, 6 months ago (2017-06-15 20:46:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/7850)
3 years, 6 months ago (2017-06-15 21:20:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941123002/40001
3 years, 6 months ago (2017-06-22 17:22:10 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 17:47:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698