Added initial muted state to stream creation callback, to avoid races.

Added initial muted state to stream creation callback, to avoid races.

BUG=chromium:729002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2941773002
Cr-Commit-Position: refs/heads/master@{#482269}
Committed: https://chromium.googlesource.com/chromium/src/+/227cd1ee0e84c4673305849a50d5386a07533e26

[ossu-chromium, 2017-06-14 14:02:57]

Description was changed from

==========
Added initial muted state to stream creation callback, to avoid races.

BUG=chromium:729002
==========

to

==========
Added initial muted state to stream creation callback, to avoid races.

BUG=chromium:729002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ossu-chromium, 2017-06-14 14:05:01]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 14:05:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 16:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 16:23:36]

Dry run: This issue passed the CQ dry run.

[ossu-chromium, 2017-06-14 17:25:41]

ossu@chromium.org changed reviewers:
+ maxmorin@chromium.org

[ossu-chromium, 2017-06-14 17:25:42]

The tests in the final CL revealed that there's a small window between OnCreated
and OnMuted which sometimes causes the initial muted state to be wrong. This CL
addresses that by sending that info along with OnCreated.

In practice, I'm not sure the discrepancy is that much of a problem, though.
IIUC, The first muted status would then arrive as a callback, instead of being
correct directly in the getUserMedia callback. That would cause the (current)
test to fail, but maybe I should just try and change the test. WDYT?

[Max Morin, 2017-06-15 07:53:21]

I figured it was fine for the muted state to be updated after the stream was
created. That said, this is fine if it simplifies tests/web development. lgtm.

[ossu-chromium, 2017-06-22 10:17:13]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 10:17:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 14:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 14:51:06]

Dry run: This issue passed the CQ dry run.

[ossu-chromium, 2017-06-22 15:36:05]

ossu@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dcheng@chromium.org, jochen@chromium.org

[ossu-chromium, 2017-06-22 15:36:06]

Second part of changes to communicated muted state to JavaScript. The initial
muted state is necessary to ensure muted is correct when the getUserMedia
callback is executed. 

Adding:
dalecurtis@ for media/ and most of content/browser, content/renderer/media
dcheng@ for audio_messages.h
jochen@ for content/renderer/pepper and content/browser/speech (essentially noop
changes there).

[jochen (gone - plz use gerrit), 2017-06-22 16:19:31]

lgtm

[DaleCurtis, 2017-06-22 16:39:59]

media/ lgtm

[dcheng, 2017-06-22 19:59:32]

lgtm

[ossu-chromium, 2017-06-26 09:46:19]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 09:46:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 11:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 11:45:39]

Dry run: This issue passed the CQ dry run.

[ossu-chromium, 2017-06-26 14:23:24]

The CQ bit was checked by ossu@chromium.org

[ossu-chromium, 2017-06-26 14:23:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxmorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2941773002/#ps60001
(title: "Added mute information to DoCompleteCreation log message.")

[commit-bot: I haz the power, 2017-06-26 14:23:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 14:27:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498487004601410,
"parent_rev": "482c293107ddcf4d7028b5033604b0ee26288e51", "commit_rev":
"227cd1ee0e84c4673305849a50d5386a07533e26"}

[commit-bot: I haz the power, 2017-06-26 14:27:40]

Description was changed from

==========
Added initial muted state to stream creation callback, to avoid races.

BUG=chromium:729002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Added initial muted state to stream creation callback, to avoid races.

BUG=chromium:729002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2941773002
Cr-Commit-Position: refs/heads/master@{#482269}
Committed:
https://chromium.googlesource.com/chromium/src/+/227cd1ee0e84c4673305849a50d5...
==========

[commit-bot: I haz the power, 2017-06-26 14:27:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/227cd1ee0e84c4673305849a50d5...