Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: net/spdy/chromium/spdy_session_unittest.cc

Issue 2943113002: Reset pushed stream unless using GET or HEAD method. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/chromium/spdy_session.cc ('k') | net/spdy/chromium/spdy_test_util_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/chromium/spdy_session_unittest.cc
diff --git a/net/spdy/chromium/spdy_session_unittest.cc b/net/spdy/chromium/spdy_session_unittest.cc
index 4b6013286847c4c97038bbd7c15a6170bb10460d..d14187178359083d05129043012d0ae7d276fdcc 100644
--- a/net/spdy/chromium/spdy_session_unittest.cc
+++ b/net/spdy/chromium/spdy_session_unittest.cc
@@ -5222,6 +5222,7 @@ TEST_F(SpdySessionTest, IgnoreReservedRemoteStreamsCount) {
SpdySerializedFrame push_a(spdy_util_.ConstructSpdyPush(
nullptr, 0, 2, 1, "https://www.example.org/a.dat"));
SpdyHeaderBlock push_headers;
+ push_headers[":method"] = "GET";
spdy_util_.AddUrlToHeaderBlock("https://www.example.org/b.dat",
&push_headers);
SpdySerializedFrame push_b(
@@ -5316,6 +5317,7 @@ TEST_F(SpdySessionTest, IgnoreReservedRemoteStreamsCount) {
TEST_F(SpdySessionTest, CancelReservedStreamOnHeadersReceived) {
const char kPushedUrl[] = "https://www.example.org/a.dat";
SpdyHeaderBlock push_headers;
+ push_headers[":method"] = "GET";
spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_headers);
SpdySerializedFrame push_promise(
spdy_util_.ConstructInitialSpdyPushFrame(std::move(push_headers), 2, 1));
« no previous file with comments | « net/spdy/chromium/spdy_session.cc ('k') | net/spdy/chromium/spdy_test_util_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698