Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2943113002: Reset pushed stream unless using GET or HEAD method. (Closed)

Created:
10 months, 1 week ago by Bence
Modified:
10 months, 1 week ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset pushed stream unless using GET or HEAD method. BUG=727653 Review-Url: https://codereview.chromium.org/2943113002 Cr-Commit-Position: refs/heads/master@{#480423} Committed: https://chromium.googlesource.com/chromium/src/+/c055fa3cd18ce9414f250566de0b17265458ca2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M net/spdy/chromium/spdy_network_transaction_unittest.cc View 4 chunks +60 lines, -0 lines 0 comments Download
M net/spdy/chromium/spdy_session.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/spdy/chromium/spdy_session_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/chromium/spdy_test_util_common.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Bence
Ryan: PTAL. Thank you.
10 months, 1 week ago (2017-06-16 17:30:56 UTC) #6
Ryan Hamilton
lgtm Can you confirm that QUIC does the same thing? (Or ask Buck or Cherie ...
10 months, 1 week ago (2017-06-19 04:03:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943113002/1
10 months, 1 week ago (2017-06-19 12:13:42 UTC) #9
commit-bot: I haz the power
10 months, 1 week ago (2017-06-19 13:44:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c055fa3cd18ce9414f250566de0b...

Powered by Google App Engine
This is Rietveld 408576698