Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2943113002: Reset pushed stream unless using GET or HEAD method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Bence
Modified:
2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset pushed stream unless using GET or HEAD method. BUG=727653 Review-Url: https://codereview.chromium.org/2943113002 Cr-Commit-Position: refs/heads/master@{#480423} Committed: https://chromium.googlesource.com/chromium/src/+/c055fa3cd18ce9414f250566de0b17265458ca2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M net/spdy/chromium/spdy_network_transaction_unittest.cc View 4 chunks +60 lines, -0 lines 0 comments Download
M net/spdy/chromium/spdy_session.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/spdy/chromium/spdy_session_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/chromium/spdy_test_util_common.cc View 2 chunks +2 lines, -0 lines 0 comments Download
Trybot results:  linux_chromium_chromeos_ozone_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   ios-device   linux_chromium_tsan_rel_ng   chromium_presubmit   ios-simulator   cast_shell_linux   win_chromium_rel_ng   mac_chromium_rel_ng   android_clang_dbg_recipe   android_n5x_swarming_rel   win_clang   mac_chromium_compile_dbg_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   cast_shell_android   android_arm64_dbg_recipe   linux_android_rel_ng   linux_chromium_headless_rel   linux_chromium_chromeos_rel_ng   win_chromium_compile_dbg_ng   android_compile_dbg   ios-simulator-xcode-clang   ios-device-xcode-clang   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   win_chromium_x64_rel_ng   android_cronet   linux_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_tsan_rel_ng   ios-device   ios-simulator   chromium_presubmit   cast_shell_linux   win_chromium_rel_ng   mac_chromium_rel_ng   android_n5x_swarming_rel   android_clang_dbg_recipe   win_clang   mac_chromium_compile_dbg_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   cast_shell_android   android_arm64_dbg_recipe   linux_android_rel_ng   win_chromium_compile_dbg_ng   linux_chromium_headless_rel   linux_chromium_chromeos_rel_ng   android_compile_dbg   ios-simulator-xcode-clang   ios-device-xcode-clang   chromeos_daisy_chromium_compile_only_ng   linux_chromium_asan_rel_ng   win_chromium_x64_rel_ng   android_cronet 
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
Bence
Ryan: PTAL. Thank you.
2 months ago (2017-06-16 17:30:56 UTC) #6
Ryan Hamilton
lgtm Can you confirm that QUIC does the same thing? (Or ask Buck or Cherie ...
2 months ago (2017-06-19 04:03:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943113002/1
2 months ago (2017-06-19 12:13:42 UTC) #9
commit-bot: I haz the power
2 months ago (2017-06-19 13:44:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c055fa3cd18ce9414f250566de0b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b