Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2943263003: Make WeakContainer safe when weak_nsobject.h is included from ARC code. (Closed)

Created:
5 months, 3 weeks ago by stkhapugin
Modified:
5 months, 3 weeks ago
CC:
chromium-reviews, danakj+watch_chromium.org, ios-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WeakContainer safe when weak_nsobject.h is included from ARC code. Makes base::WeakContainer constructor and destructor non-inline, and makes the backing variable |object_| unsafe_unretained. This guarantees that when included from ARC code, the non-ARC version of implementation for the destructor will be used, and no extra release calls will be issued. BUG=None TEST=None Review-Url: https://codereview.chromium.org/2943263003 Cr-Commit-Position: refs/heads/master@{#480413} Committed: https://chromium.googlesource.com/chromium/src/+/18b1184609fbfbe22e773540bc826eb8aa4b5572

Patch Set 1 #

Messages

Total messages: 16 (9 generated)
stkhapugin
PTAL
5 months, 3 weeks ago (2017-06-19 12:05:57 UTC) #3
sdefresne
lgtm +rohitrao: please take a look too
5 months, 3 weeks ago (2017-06-19 12:32:02 UTC) #6
rohitrao (ping after 24h)
How did we figure out that this was broken? Was there a bug or some ...
5 months, 3 weeks ago (2017-06-19 12:34:25 UTC) #9
rohitrao (ping after 24h)
lgtm
5 months, 3 weeks ago (2017-06-19 12:35:46 UTC) #10
sdefresne
On 2017/06/19 12:34:25, rohitrao (ping after 24h) wrote: > How did we figure out that ...
5 months, 3 weeks ago (2017-06-19 12:42:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943263003/1
5 months, 3 weeks ago (2017-06-19 12:43:01 UTC) #13
commit-bot: I haz the power
5 months, 3 weeks ago (2017-06-19 12:47:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18b1184609fbfbe22e773540bc82...

Powered by Google App Engine
This is Rietveld 0eb02b776