Improve dialog titles generated by embedded pages.

Improve dialog titles generated by embedded pages.

BUG=590815
TEST=See steps to reproduce in bug.

Review-Url: https://codereview.chromium.org/2944243002
Cr-Commit-Position: refs/heads/master@{#481591}
Committed: https://chromium.googlesource.com/chromium/src/+/4da94ecef84eb4c38c68952b54f28b1159289998

[PL, 2017-06-20 01:15:18]

peterlaurens@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[PL, 2017-06-20 01:15:19]

Hi Kurt!

PTAL! This correctly presents the appropriate title instead of about:null now.

The desktop code seems to compare the origin URL of the current WebContents and
the origin URL of the passed in URL. I'm not sure this is necessary for our
change here? (And would require significant plumbing I think).

Thanks!

[kkhorimoto, 2017-06-22 01:05:07]

lgtm!

[PL, 2017-06-22 17:33:50]

The CQ bit was checked by peterlaurens@chromium.org

[commit-bot: I haz the power, 2017-06-22 17:34:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 17:47:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498152830016890, "parent_rev":
"9f1b6e0775d4a97df66d39197df9c6a01a41539b", "commit_rev":
"4da94ecef84eb4c38c68952b54f28b1159289998"}

[commit-bot: I haz the power, 2017-06-22 17:47:40]

Description was changed from

==========
Improve dialog titles generated by embedded pages.

BUG=590815
TEST=See steps to reproduce in bug.
==========

to

==========
Improve dialog titles generated by embedded pages.

BUG=590815
TEST=See steps to reproduce in bug.

Review-Url: https://codereview.chromium.org/2944243002
Cr-Commit-Position: refs/heads/master@{#481591}
Committed:
https://chromium.googlesource.com/chromium/src/+/4da94ecef84eb4c38c68952b54f2...
==========

[commit-bot: I haz the power, 2017-06-22 17:47:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4da94ecef84eb4c38c68952b54f2...

[Eugene But (OOO till 7-30), 2017-06-22 20:19:12]

eugenebut@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-06-22 20:19:13]

Driving by

https://codereview.chromium.org/2944243002/diff/1/ios/chrome/browser/ui/dialo...
File ios/chrome/browser/ui/dialogs/dialog_presenter.mm (right):

https://codereview.chromium.org/2944243002/diff/1/ios/chrome/browser/ui/dialo...
ios/chrome/browser/ui/dialogs/dialog_presenter.mm:346: if (!hostname.length) {
Other platforms use IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME when
dialog is requested by iframe, not when hostname is empty. Can we follow the
same logic as other platforms?:

bool is_same_origin_as_main_frame =
      (web_contents->GetURL().GetOrigin() == origin_url.GetOrigin());

ios has web_state instead of web_contents, but everything else can be the same.

[PL, 2017-06-22 20:24:32]

On 2017/06/22 20:19:13, Eugene But wrote:
> Driving by
> 
>
https://codereview.chromium.org/2944243002/diff/1/ios/chrome/browser/ui/dialo...
> File ios/chrome/browser/ui/dialogs/dialog_presenter.mm (right):
> 
>
https://codereview.chromium.org/2944243002/diff/1/ios/chrome/browser/ui/dialo...
> ios/chrome/browser/ui/dialogs/dialog_presenter.mm:346: if (!hostname.length) {
> Other platforms use IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME
when
> dialog is requested by iframe, not when hostname is empty. Can we follow the
> same logic as other platforms?:
> 
> bool is_same_origin_as_main_frame =
>       (web_contents->GetURL().GetOrigin() == origin_url.GetOrigin());
> 
> ios has web_state instead of web_contents, but everything else can be the
same.

Thanks Eugene! I will follow up in a new CL.

[Eugene But (OOO till 7-30), 2017-06-22 20:52:01]

On 2017/06/22 20:24:32, PL wrote:
> On 2017/06/22 20:19:13, Eugene But wrote:
> > Driving by
> > 
> >
>
https://codereview.chromium.org/2944243002/diff/1/ios/chrome/browser/ui/dialo...
> > File ios/chrome/browser/ui/dialogs/dialog_presenter.mm (right):
> > 
> >
>
https://codereview.chromium.org/2944243002/diff/1/ios/chrome/browser/ui/dialo...
> > ios/chrome/browser/ui/dialogs/dialog_presenter.mm:346: if (!hostname.length)
{
> > Other platforms use IDS_JAVASCRIPT_MESSAGEBOX_TITLE_NONSTANDARD_URL_IFRAME
> when
> > dialog is requested by iframe, not when hostname is empty. Can we follow the
> > same logic as other platforms?:
> > 
> > bool is_same_origin_as_main_frame =
> >       (web_contents->GetURL().GetOrigin() == origin_url.GetOrigin());
> > 
> > ios has web_state instead of web_contents, but everything else can be the
> same.
> 
> Thanks Eugene! I will follow up in a new CL.
Thank you!