Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs.

Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs.

BUG=
R=whesse@google.com

Committed: https://github.com/dart-lang/http_server/commit/45e341aadec5ab902108a7e1f93585f367d13a9f

[keertip, 2017-06-22 18:18:20]

Description was changed from

==========
Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs.

BUG=
==========

to

==========
Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs.

BUG=
==========

[keertip, 2017-06-22 18:18:20]

keertip@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2017-06-22 21:17:34]

I haven't really worked on this package at all; maybe send this to whesse? It
looks like he touched it last.

[keertip, 2017-06-22 21:20:49]

keertip@google.com changed reviewers:
+ whesse@google.com
- nweiz@google.com

[Bill Hesse, 2017-06-23 13:49:08]

LGTM.

https://codereview.chromium.org/2945343002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2945343002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.9.6-dev
0.9.6 has been published already.  I don't think you can go back to an earlier
version.  Should this be 0.9.7-dev.0?  Or just 0.9.7?

https://codereview.chromium.org/2945343002/diff/1/test/http_body_test.dart
File test/http_body_test.dart (right):

https://codereview.chromium.org/2945343002/diff/1/test/http_body_test.dart#ne...
test/http_body_test.dart:17: HttpServer.bind("localhost", 0).then((server) {
Consider if you want to use InternetAddress.lookup(), and then use the returned
InternetAddress to call bind and connect?

[keertip, 2017-06-27 17:51:06]

https://codereview.chromium.org/2945343002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2945343002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.9.6-dev
On 2017/06/23 13:49:07, Bill Hesse wrote:
> 0.9.6 has been published already.  I don't think you can go back to an earlier
> version.  Should this be 0.9.7-dev.0?  Or just 0.9.7?

changed to 0.9.7-dev.

https://codereview.chromium.org/2945343002/diff/1/test/http_body_test.dart
File test/http_body_test.dart (right):

https://codereview.chromium.org/2945343002/diff/1/test/http_body_test.dart#ne...
test/http_body_test.dart:17: HttpServer.bind("localhost", 0).then((server) {
On 2017/06/23 13:49:08, Bill Hesse wrote:
> Consider if you want to use InternetAddress.lookup(), and then use the
returned
> InternetAddress to call bind and connect?

Acknowledged.

[keertip, 2017-06-27 17:51:41]

Description was changed from

==========
Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs.

BUG=
==========

to

==========
Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs.

BUG=
R=whesse@google.com

Committed:
https://github.com/dart-lang/http_server/commit/45e341aadec5ab902108a7e1f9358...
==========

[keertip, 2017-06-27 17:51:42]

Committed patchset #2 (id:20001) manually as
45e341aadec5ab902108a7e1f93585f367d13a9f (presubmit successful).