cros: stop forcing off display when powerd reports SuspendDone

cros: stop forcing off display when powerd reports SuspendDone

Changes:
As title: stop forcing off display when powerd reports SuspendDone for
convertible/tablet device. There can be edge case that "system suspends
with backlights forced off, and then user presses power button, which
will resume system, but this power button event is not delivered to
Chrome. When powerd reports SuspendDone, we can do stopping forcing off
anyway to prevent this kind of edge case.

R=derat@chromium.org
BUG=735291
TEST=added test coverage
TabletPowerButtonControllerTest.SuspendDoneStopsForcingOff

Review-Url: https://codereview.chromium.org/2946233003
Cr-Commit-Position: refs/heads/master@{#481617}
Committed: https://chromium.googlesource.com/chromium/src/+/be4e46518a93692f402a69363bcaab66ae11b1e3

[Daniel Erat, 2017-06-22 18:08:40]

lgtm

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
File ash/system/power/tablet_power_button_controller.cc (right):

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
ash/system/power/tablet_power_button_controller.cc:164: // resuming, but power
button event is not delivered.
nit: maybe just something like:

// Stop forcing backlights off on resume to handle situations
// where the power button resumed but we didn't receive the
// event: http://crbug.com/735291

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
File ash/system/power/tablet_power_button_controller_unittest.cc (right):

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
ash/system/power/tablet_power_button_controller_unittest.cc:571: // Tests that
system is suspended with backlights forced off, and then system
nit: s/Tests that system/Tests that when system/

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
ash/system/power/tablet_power_button_controller_unittest.cc:573: //
(crbug.com/735291), that we shall still stop forcing off backlights.
nit: remove "shall still"

[Qiang(Joe) Xu, 2017-06-22 18:36:37]

done, thanks for review!

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
File ash/system/power/tablet_power_button_controller.cc (right):

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
ash/system/power/tablet_power_button_controller.cc:164: // resuming, but power
button event is not delivered.
On 2017/06/22 18:08:40, Daniel Erat wrote:
> nit: maybe just something like:
> 
> // Stop forcing backlights off on resume to handle situations
> // where the power button resumed but we didn't receive the
> // event: http://crbug.com/735291

Done.

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
File ash/system/power/tablet_power_button_controller_unittest.cc (right):

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
ash/system/power/tablet_power_button_controller_unittest.cc:571: // Tests that
system is suspended with backlights forced off, and then system
On 2017/06/22 18:08:40, Daniel Erat wrote:
> nit: s/Tests that system/Tests that when system/

Done.

https://codereview.chromium.org/2946233003/diff/1/ash/system/power/tablet_pow...
ash/system/power/tablet_power_button_controller_unittest.cc:573: //
(crbug.com/735291), that we shall still stop forcing off backlights.
On 2017/06/22 18:08:40, Daniel Erat wrote:
> nit: remove "shall still"

Done.

[Qiang(Joe) Xu, 2017-06-22 18:36:41]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2017-06-22 18:36:42]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2946233003/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-06-22 18:37:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 19:11:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498156601873780,
"parent_rev": "9480c74ef7393af405e7f9dbee4a10bd3e8dd64d", "commit_rev":
"be4e46518a93692f402a69363bcaab66ae11b1e3"}

[commit-bot: I haz the power, 2017-06-22 19:11:57]

Description was changed from

==========
cros: stop forcing off display when powerd reports SuspendDone

Changes:
As title: stop forcing off display when powerd reports SuspendDone for
convertible/tablet device. There can be edge case that "system suspends
with backlights forced off, and then user presses power button, which
will resume system, but this power button event is not delivered to
Chrome. When powerd reports SuspendDone, we can do stopping forcing off
anyway to prevent this kind of edge case.

R=derat@chromium.org
BUG=735291
TEST=added test coverage
TabletPowerButtonControllerTest.SuspendDoneStopsForcingOff
==========

to

==========
cros: stop forcing off display when powerd reports SuspendDone

Changes:
As title: stop forcing off display when powerd reports SuspendDone for
convertible/tablet device. There can be edge case that "system suspends
with backlights forced off, and then user presses power button, which
will resume system, but this power button event is not delivered to
Chrome. When powerd reports SuspendDone, we can do stopping forcing off
anyway to prevent this kind of edge case.

R=derat@chromium.org
BUG=735291
TEST=added test coverage
TabletPowerButtonControllerTest.SuspendDoneStopsForcingOff

Review-Url: https://codereview.chromium.org/2946233003
Cr-Commit-Position: refs/heads/master@{#481617}
Committed:
https://chromium.googlesource.com/chromium/src/+/be4e46518a93692f402a69363bca...
==========

[commit-bot: I haz the power, 2017-06-22 19:11:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be4e46518a93692f402a69363bca...