Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: components/signin/core/browser/signin_header_helper.cc

Issue 2946693002: Use GN buildflags and features to configure account consistency (Closed)
Patch Set: fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_header_helper.cc
diff --git a/components/signin/core/browser/signin_header_helper.cc b/components/signin/core/browser/signin_header_helper.cc
index 0331f65797008af5ab505113dacca62d969c31f5..1c1bbc86b7650cd5ae008e94bfb3e30251b3dc77 100644
--- a/components/signin/core/browser/signin_header_helper.cc
+++ b/components/signin/core/browser/signin_header_helper.cc
@@ -18,7 +18,7 @@
#include "net/base/escape.h"
#include "net/url_request/url_request.h"
-#if !defined(OS_IOS) && !defined(OS_ANDROID)
+#if BUILDFLAG(ENABLE_DICE_SUPPORT)
#include "components/signin/core/browser/dice_header_helper.h"
#endif
@@ -127,8 +127,7 @@ void AppendOrRemoveAccountConsistentyRequestHeader(
const content_settings::CookieSettings* cookie_settings,
int profile_mode_mask) {
const GURL& url = redirect_url.is_empty() ? request->url() : redirect_url;
-// Dice is not enabled on mobile.
-#if !defined(OS_IOS) && !defined(OS_ANDROID)
+#if BUILDFLAG(ENABLE_DICE_SUPPORT)
DiceHeaderHelper dice_helper;
std::string dice_header_value;
if (dice_helper.ShouldBuildRequestHeader(url, cookie_settings)) {
@@ -155,7 +154,7 @@ ManageAccountsParams BuildManageAccountsParams(
return ChromeConnectedHeaderHelper::BuildManageAccountsParams(header_value);
}
-#if !defined(OS_IOS) && !defined(OS_ANDROID)
+#if BUILDFLAG(ENABLE_DICE_SUPPORT)
DiceResponseParams BuildDiceResponseParams(const std::string& header_value) {
return DiceHeaderHelper::BuildDiceResponseParams(header_value);
}
« no previous file with comments | « components/signin/core/browser/signin_header_helper.h ('k') | components/signin/core/browser/signin_header_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698