Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: components/signin/core/browser/signin_header_helper_unittest.cc

Issue 2946693002: Use GN buildflags and features to configure account consistency (Closed)
Patch Set: fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/signin/core/browser/signin_header_helper.cc ('k') | components/signin/core/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/signin_header_helper_unittest.cc
diff --git a/components/signin/core/browser/signin_header_helper_unittest.cc b/components/signin/core/browser/signin_header_helper_unittest.cc
index ed9f17b19b3c48fc255d493ae72ebd22f1e2444d..8246c211833082fc45301feeb459a5363f5aa046 100644
--- a/components/signin/core/browser/signin_header_helper_unittest.cc
+++ b/components/signin/core/browser/signin_header_helper_unittest.cc
@@ -10,10 +10,10 @@
#include "base/command_line.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
-#include "build/build_config.h"
#include "components/content_settings/core/browser/cookie_settings.h"
#include "components/signin/core/browser/chrome_connected_header_helper.h"
#include "components/signin/core/common/profile_management_switches.h"
+#include "components/signin/core/common/signin_features.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "google_apis/gaia/gaia_urls.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
@@ -21,7 +21,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
-#if !defined(OS_IOS) && !defined(OS_ANDROID)
+#if BUILDFLAG(ENABLE_DICE_SUPPORT)
#include "components/signin/core/browser/dice_header_helper.h"
#endif
@@ -86,7 +86,7 @@ class SigninHeaderHelperTest : public testing::Test {
url_request.get(), kChromeConnectedHeader, expected_request);
}
-#if !defined(OS_IOS) && !defined(OS_ANDROID)
+#if BUILDFLAG(ENABLE_DICE_SUPPORT)
void CheckDiceHeaderRequest(const GURL& url,
const std::string& account_id,
bool sync_enabled,
@@ -162,7 +162,7 @@ TEST_F(SigninHeaderHelperTest, TestMirrorRequestGoogleCom) {
// Mirror is always enabled on Android and iOS, so these tests are only relevant
// on Desktop.
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#if BUILDFLAG(ENABLE_DICE_SUPPORT)
// Tests that the Mirror request is returned when the target is a Gaia URL, even
// if account consistency is disabled.
@@ -287,7 +287,7 @@ TEST_F(SigninHeaderHelperTest, TestBuildDiceResponseParams) {
}
}
-#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
+#endif // BUILDFLAG(ENABLE_DICE_SUPPORT)
// Tests that the Mirror header request is returned normally when the redirect
// URL is eligible.
« no previous file with comments | « components/signin/core/browser/signin_header_helper.cc ('k') | components/signin/core/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698