[iOS Clean] Removed old overlay implementation.

[iOS Clean] Removed old overlay implementation.

This has been replaced with OverlayService.  This CL also updates
the SettingsCoordinator to be presented via the OverlayService.

BUG=none

[kkhorimoto, 2017-06-17 01:59:37]

kkhorimoto@chromium.org changed reviewers:
+ marq@chromium.org

[marq (ping after 24h), 2017-06-21 09:53:19]

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/settings/settings_coordinator.h (right):

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/settings/settings_coordinator.h:10: #import
"ios/clean/chrome/browser/ui/overlays/browser_coordinator+overlay_support.h"
No need to include the category here, right?

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm (right):

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm:134:
OverlayServiceFactory::GetInstance()
This is kind of an unwieldy invocation; can't it be folded into a category
method on BrowserCoordinator?

https://codereview.chromium.org/2948463002/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm (left):

https://codereview.chromium.org/2948463002/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm:21:
@property(nonatomic, readwrite) BOOL overlaying;
You will also need to fix the unit tests for overlay support in coordinators.

[kkhorimoto, 2017-06-23 06:21:57]

rebase & Mark's comments

[kkhorimoto, 2017-06-23 06:22:40]

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/settings/settings_coordinator.h (right):

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/settings/settings_coordinator.h:10: #import
"ios/clean/chrome/browser/ui/overlays/browser_coordinator+overlay_support.h"
On 2017/06/21 09:53:19, marq (ping after 24h) wrote:
> No need to include the category here, right?

Nope, changed to just browser_coordinator.h

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm (right):

https://codereview.chromium.org/2948463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm:134:
OverlayServiceFactory::GetInstance()
On 2017/06/21 09:53:19, marq (ping after 24h) wrote:
> This is kind of an unwieldy invocation; can't it be folded into a category
> method on BrowserCoordinator?

Done.

https://codereview.chromium.org/2948463002/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm (left):

https://codereview.chromium.org/2948463002/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm:21:
@property(nonatomic, readwrite) BOOL overlaying;
On 2017/06/21 09:53:19, marq (ping after 24h) wrote:
> You will also need to fix the unit tests for overlay support in coordinators. 

Done.

[marq (ping after 24h), 2017-06-23 10:47:55]

LGTM