Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 2948943004: Remove Sad Tab suggestion to close other apps (Closed)

Created:
3 years, 6 months ago by PL
Modified:
3 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Sad Tab suggestion to close other apps BUG=735475 TEST=The repeated crash sad tab page (feedback) does not advise that other apps be closed. Review-Url: https://codereview.chromium.org/2948943004 Cr-Commit-Position: refs/heads/master@{#481593} Committed: https://chromium.googlesource.com/chromium/src/+/d54a92e6ed393729e51d49004d44698d7fce570c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ios/chrome/browser/ui/sad_tab/sad_tab_view.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
PL
Hello! This is a change requested after UI review that we do not advise users ...
3 years, 6 months ago (2017-06-21 21:15:07 UTC) #2
kkhorimoto
lgtm
3 years, 6 months ago (2017-06-22 00:49:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948943004/1
3 years, 6 months ago (2017-06-22 17:34:24 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 17:52:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d54a92e6ed393729e51d49004d44...

Powered by Google App Engine
This is Rietveld 408576698