scheduler: more of s/JobID/JobName/ where JobID != Job.JobID.

scheduler: more of s/JobID/JobName/ where JobID != Job.JobID.

Also moves acls stub from ui to presentation, as the stub will be shared
with apiserver.

R=vadimsh@chromium.org
Bug: 712427
Review-Url: https://codereview.chromium.org/2949093003
Committed: https://github.com/luci/luci-go/commit/b080ae464250e8d831a5d8ce09d00d781ae1528b

[tandrii(chromium), 2017-06-21 21:08:20]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 21:08:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 21:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 21:15:37]

Dry run: This issue passed the CQ dry run.

[Vadim Sh., 2017-06-21 23:39:09]

lgtm, but you missed a spot

https://codereview.chromium.org/2949093003/diff/1/scheduler/appengine/ui/invo...
File scheduler/appengine/ui/invocation.go (right):

https://codereview.chromium.org/2949093003/diff/1/scheduler/appengine/ui/invo...
scheduler/appengine/ui/invocation.go:82: jobID := c.Params.ByName("JobID")
JobName here (and in all similar places).

ByName(...) here refers to URL parameters specified r.POST(....).

[tandrii(chromium), 2017-06-22 15:52:38]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 15:52:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2017-06-22 15:52:55]

https://codereview.chromium.org/2949093003/diff/1/scheduler/appengine/ui/invo...
File scheduler/appengine/ui/invocation.go (right):

https://codereview.chromium.org/2949093003/diff/1/scheduler/appengine/ui/invo...
scheduler/appengine/ui/invocation.go:82: jobID := c.Params.ByName("JobID")
On 2017/06/21 23:39:09, Vadim Sh. wrote:
> JobName here (and in all similar places).
> 
> ByName(...) here refers to URL parameters specified r.POST(....).

oops, indeed I missed these.

[commit-bot: I haz the power, 2017-06-22 15:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 15:57:55]

Dry run: This issue passed the CQ dry run.

[Vadim Sh., 2017-06-22 17:09:01]

lgtm

[tandrii(chromium), 2017-06-22 17:57:29]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2017-06-22 17:57:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 18:01:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498154249927280,
"parent_rev": "7c3b1e060dd19bad03f926f6cacc220a3182babd", "commit_rev":
"b080ae464250e8d831a5d8ce09d00d781ae1528b"}

[commit-bot: I haz the power, 2017-06-22 18:02:01]

Description was changed from

==========
scheduler: more of s/JobID/JobName/ where JobID != Job.JobID.

Also moves acls stub from ui to presentation, as the stub will be shared
with apiserver.

R=vadimsh@chromium.org
Bug: 712427
==========

to

==========
scheduler: more of s/JobID/JobName/ where JobID != Job.JobID.

Also moves acls stub from ui to presentation, as the stub will be shared
with apiserver.

R=vadimsh@chromium.org
Bug: 712427
Review-Url: https://codereview.chromium.org/2949093003
Committed:
https://github.com/luci/luci-go/commit/b080ae464250e8d831a5d8ce09d00d781ae1528b
==========

[commit-bot: I haz the power, 2017-06-22 18:02:02]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/b080ae464250e8d831a5d8ce09d00d781ae1528b