[Android] Fix context menu animation errors for Browser Actions

[Android] Fix context menu animation errors for Browser Actions

This CL fixes two issues about animation of Chrome context menu for
Browser Actions:
1. NullPointerException for getContentOffsetYPix because Browser Actions
does not have ContentViewCore. To fix it, add a check if null, return 0.
2. Browser Actions request does not provide the touch event coordinates
and sets them to 0 when displaying the context menu. This forces context
menu to be displayed from top left. The ideal performance should display
the context menu from center. To fix it, if the Activity is a
BrowserActionActivity, set ScaleAnimation to animate from center.

BUG=None

Review-Url: https://codereview.chromium.org/2949153002
Cr-Commit-Position: refs/heads/master@{#481983}
Committed: https://chromium.googlesource.com/chromium/src/+/8858b0ca87b50b3aa49aca753e0a520c06bcdfc4

[ltian, 2017-06-22 01:24:40]

ltian@chromium.org changed reviewers:
+ danielpark@chromium.org, tedchoc@chromium.org, twellington@chromium.org

[ltian, 2017-06-22 01:24:41]

Could you take a look of this changes?

Thanks!

[Theresa, 2017-06-22 15:07:29]

Will you please file a bug for this and upload some videos of the animation?

https://codereview.chromium.org/2949153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java
(right):

https://codereview.chromium.org/2949153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java:56:
float touchPointYPx, View contentView, RenderCoordinates renderCoordinates) {
Add @Nullable annotation to RendererCoordinates and comment in the JavaDoc that
this param may be null.

https://codereview.chromium.org/2949153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java:166:
if (mActivity instanceof BrowserActionActivity) {
Instead of checking for BrowserActionActivity explicitly, let's animate from the
center if the RendererCoordinates are null.

Also, what does this look like if you construct a ScaleAnimation without any
pivots using this constructor:
ScaleAnimation(float fromX, float toX, float fromY, float toY);

[ltian, 2017-06-22 18:18:08]

https://codereview.chromium.org/2949153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java
(right):

https://codereview.chromium.org/2949153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java:56:
float touchPointYPx, View contentView, RenderCoordinates renderCoordinates) {
On 2017/06/22 15:07:29, Theresa wrote:
> Add @Nullable annotation to RendererCoordinates and comment in the JavaDoc
that
> this param may be null.

Done.

https://codereview.chromium.org/2949153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java:166:
if (mActivity instanceof BrowserActionActivity) {
On 2017/06/22 15:07:29, Theresa wrote:
> Instead of checking for BrowserActionActivity explicitly, let's animate from
the
> center if the RendererCoordinates are null.
> 
> Also, what does this look like if you construct a ScaleAnimation without any
> pivots using this constructor:
> ScaleAnimation(float fromX, float toX, float fromY, float toY);

ScaleAnimation(fromX, toX, fromY, toY) displays the context menu from the top
left point of the menu.

ScaleAnimation(fromX, toX, fromY, toY, Animation.ABSOLUTE, pivotX,
Animation.ABSOLUTE, pivotY) displays the context menu from the top left of the
screen.

ScaleAnimation(fromX, toX, fromY, toY, Animation.RELATIVE_TO_SELF, 0.5f,
Animation.RELATIVE_TO_SELF, 0.5f) displays the menu from the center of the
screen.

[Theresa, 2017-06-22 23:33:42]

lgtm

https://codereview.chromium.org/2949153002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java
(right):

https://codereview.chromium.org/2949153002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java:170:
Animation.RELATIVE_TO_SELF, 0.5f);
I think ideally we would skip calculating the pivot points if we're not going to
use them, but I'm okay with this.

[Ted C, 2017-06-23 18:15:41]

lgtm

[ltian, 2017-06-23 18:16:19]

The CQ bit was checked by ltian@chromium.org

[commit-bot: I haz the power, 2017-06-23 18:16:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 19:08:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498241779665960,
"parent_rev": "9038baea6db2fbda8b0638dfded93e3d01e4130e", "commit_rev":
"8858b0ca87b50b3aa49aca753e0a520c06bcdfc4"}

[commit-bot: I haz the power, 2017-06-23 19:09:15]

Description was changed from

==========
[Android] Fix context menu animation errors for Browser Actions

This CL fixes two issues about animation of Chrome context menu for
Browser Actions:
1. NullPointerException for getContentOffsetYPix because Browser Actions
does not have ContentViewCore. To fix it, add a check if null, return 0.
2. Browser Actions request does not provide the touch event coordinates
and sets them to 0 when displaying the context menu. This forces context
menu to be displayed from top left. The ideal performance should display
the context menu from center. To fix it, if the Activity is a
BrowserActionActivity, set ScaleAnimation to animate from center.

BUG=None
==========

to

==========
[Android] Fix context menu animation errors for Browser Actions

This CL fixes two issues about animation of Chrome context menu for
Browser Actions:
1. NullPointerException for getContentOffsetYPix because Browser Actions
does not have ContentViewCore. To fix it, add a check if null, return 0.
2. Browser Actions request does not provide the touch event coordinates
and sets them to 0 when displaying the context menu. This forces context
menu to be displayed from top left. The ideal performance should display
the context menu from center. To fix it, if the Activity is a
BrowserActionActivity, set ScaleAnimation to animate from center.

BUG=None

Review-Url: https://codereview.chromium.org/2949153002
Cr-Commit-Position: refs/heads/master@{#481983}
Committed:
https://chromium.googlesource.com/chromium/src/+/8858b0ca87b50b3aa49aca753e0a...
==========

[commit-bot: I haz the power, 2017-06-23 19:09:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8858b0ca87b50b3aa49aca753e0a...