Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2949303002: Handle RGBA_4444 scales in > max texture size images (Closed)

Created:
3 years, 6 months ago by ericrk
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Handle RGBA_4444 scales in > max texture size images Re-land with merge fix. Currently, we have a hole in the GPU Image Decode Controller where a greater-than-max-texture-size image, rendered in non-RGBA-8888 color, and scaled down by more than 50%, will hit a guaranteed failure case in Skia. This change adds a path which works around this failure case. Bug: 733471, 735795 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d1aed82c3e4590de37eb403ffa96673fbe1e163 Reviewed-on: https://chromium-review.googlesource.com/540260 Reviewed-by: Vladimir Levin <vmpstr@chromium.org>; Commit-Queue: Eric Karl <ericrk@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#480887} Review-Url: https://codereview.chromium.org/2949303002 . Cr-Commit-Position: refs/branch-heads/3112@{#443} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c23cafd658effa3ad82eb3584eb37cb3e52d0095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -84 lines) Patch
M cc/tiles/gpu_image_decode_cache.cc View 2 chunks +33 lines, -3 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache_unittest.cc View 40 chunks +108 lines, -81 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
3 years, 6 months ago (2017-06-22 18:13:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c23cafd658effa3ad82eb3584eb37cb3e52d0095.

Powered by Google App Engine
This is Rietveld 408576698