Load vmservice from a .dill file when generating AOT snapshots.

Load vmservice from a .dill file when generating AOT snapshots.

This will happen only if --dfe option is specified along with the
--kernel-binaries option.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/a23178ee779632ef468b498e058a8f3f2f61e84b

[sivachandra, 2017-06-22 18:25:25]

sivachandra@google.com changed reviewers:
+ asiva@google.com

[sivachandra, 2017-06-22 18:25:26]

This change brings down the failures on vm-kernel-precomp bots from around 1600+
to around 100.

[The high number of failures were to due to removal of vmservice related
libraries from platform.dill.]

[sivachandra, 2017-06-22 23:33:08]

PTaL at patch set 3. Modified according to offline discussions.

[siva, 2017-06-22 23:51:37]

https://codereview.chromium.org/2949323002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2949323002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5647: static Dart_Handle
LoadLibraryFromKernel(Thread* T, void* kernel_program) {
Is it LoadLibraryFromKernel or LoadKernelProgram as we can also use this
abstraction for LoadScript.

https://codereview.chromium.org/2949323002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5657: return Api::NewHandle(T, library.raw());
I think currently reader.ReadProgram returns the library that has 'main' in it
otherwise it returns null.

You may have to instead call Library::LookupLibrary(T, url) to get the library
object and return it.

[sivachandra, 2017-06-23 01:14:57]

https://codereview.chromium.org/2949323002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2949323002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5647: static Dart_Handle
LoadLibraryFromKernel(Thread* T, void* kernel_program) {
On 2017/06/22 23:51:37, siva wrote:
> Is it LoadLibraryFromKernel or LoadKernelProgram as we can also use this
> abstraction for LoadScript.

Done.

https://codereview.chromium.org/2949323002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5657: return Api::NewHandle(T, library.raw());
On 2017/06/22 23:51:37, siva wrote:
> I think currently reader.ReadProgram returns the library that has 'main' in it
> otherwise it returns null.
> 
> You may have to instead call Library::LookupLibrary(T, url) to get the library
> object and return it.

Done.

[siva, 2017-06-23 05:23:24]

lgtm

[sivachandra, 2017-06-23 16:39:25]

Description was changed from

==========
Load vmservice from a .dill file when generating AOT snapshots.

This will happen only if --dfe option is specified along with the
--kernel-binaries option.
==========

to

==========
Load vmservice from a .dill file when generating AOT snapshots.

This will happen only if --dfe option is specified along with the
--kernel-binaries option.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a23178ee779632ef468b498e058a8f3f2f61e84b
==========

[sivachandra, 2017-06-23 16:39:29]

Committed patchset #4 (id:60001) manually as
a23178ee779632ef468b498e058a8f3f2f61e84b (presubmit successful).