third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h - Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h

Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)

Patch Set: Remove now unnecessary call from WebContentsImpl::RenderViewTerminated to delegate_->HideValidation… Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h

diff --git a/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h b/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h

index 0816472667db5d510f67d81e4ae3628f277280ad..1b61b2c518bf4156fae2ff36da2dc1281e0982a5 100644

--- a/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h

+++ b/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h

@@ -63,8 +63,6 @@ class CORE_EXPORT ValidationMessageClientImpl final

TextDirection sub_message_dir) override;

void HideValidationMessage(const Element& anchor) override;

bool IsValidationMessageVisible(const Element& anchor) override;

- void WillUnloadDocument(const Document&) override;

- void DocumentDetached(const Document&) override;

void WillBeDestroyed() override;

// PopupOpeningObserver function