PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

This is in preparation of removing Polymer's testing related files from
the production binary.

BUG=736124
Review-Url: https://codereview.chromium.org/2949883006
Cr-Commit-Position: refs/heads/master@{#482144}
Committed: https://chromium.googlesource.com/chromium/src/+/4bf10fb33e766df1ec8071c27cfb5a13dd7edc88

[dpapad, 2017-06-23 02:45:27]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 02:45:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-23 02:50:08]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 02:50:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-23 02:52:19]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-06-23 02:52:57]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dpapad, 2017-06-23 02:54:00]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 02:54:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-23 02:55:37]

Description was changed from

==========
PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

BUG=736124
==========

to

==========
PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

This is in preparation of removing Polymer's testing related files from
the production binary.

BUG=736124
==========

[commit-bot: I haz the power, 2017-06-23 04:36:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 04:36:19]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-06-23 16:14:55]

dpapad@chromium.org changed reviewers:
+ thestig@chromium.org

[dpapad, 2017-06-23 23:49:38]

On 2017/06/23 at 16:14:56, dpapad wrote:
> 

Friendly ping.

[Lei Zhang, 2017-06-24 00:13:46]

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
chrome/browser/pdf/pdf_extension_test.cc:159:
FILE_PATH_LITERAL("third_party/polymer/v1_0/components-chromium/"
Is it possible to use IDR_POLYMER_1_0_IRON_TEST_HELPERS_MOCK_INTERACTIONS_JS
instead of referring to it by path? If yes, would that be better?

[dpapad, 2017-06-24 00:40:53]

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
chrome/browser/pdf/pdf_extension_test.cc:159:
FILE_PATH_LITERAL("third_party/polymer/v1_0/components-chromium/"
On 2017/06/24 at 00:13:46, Lei Zhang wrote:
> Is it possible to use IDR_POLYMER_1_0_IRON_TEST_HELPERS_MOCK_INTERACTIONS_JS
instead of referring to it by path? If yes, would that be better?

This would defeat the purpose of this CL which is to remove mock-interactions.js
from any grd file (and therefore not having it shipped with Chrome), see next CL
which actually does this,
https://codereview.chromium.org/2949313002/diff/80001/ui/webui/resources/poly....

[Lei Zhang, 2017-06-24 00:47:59]

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
chrome/browser/pdf/pdf_extension_test.cc:159:
FILE_PATH_LITERAL("third_party/polymer/v1_0/components-chromium/"
On 2017/06/24 00:40:53, dpapad wrote:
> On 2017/06/24 at 00:13:46, Lei Zhang wrote:
> > Is it possible to use IDR_POLYMER_1_0_IRON_TEST_HELPERS_MOCK_INTERACTIONS_JS
> instead of referring to it by path? If yes, would that be better?
> 
> This would defeat the purpose of this CL which is to remove
mock-interactions.js
> from any grd file (and therefore not having it shipped with Chrome), see next
CL
> which actually does this,
>
https://codereview.chromium.org/2949313002/diff/80001/ui/webui/resources/poly....
> 

What about moving it to browser_tests.pak? i.e. move the grit entry into
chrome/test/data/webui_test_resources.grd.

[dpapad, 2017-06-24 01:07:38]

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
File chrome/browser/pdf/pdf_extension_test.cc (right):

https://codereview.chromium.org/2949883006/diff/60001/chrome/browser/pdf/pdf_...
chrome/browser/pdf/pdf_extension_test.cc:159:
FILE_PATH_LITERAL("third_party/polymer/v1_0/components-chromium/"
> What about moving it to browser_tests.pak? i.e. move the grit entry into
chrome/test/data/webui_test_resources.grd.

I can explore that if preferable, but at first glance it seems that
https://cs.chromium.org/chromium/src/chrome/test/data/webui_test_resources.grd
should only contain files that are in a subtree of its location, not from a
random third party location. Also technically the PDF plugin tests are not WebUI
tests. It would probably be better to create a
ui/webui/resources/polymer_test_resources.grdp if we want to follow the GRIT
approach.

My understanding is that both GRIT and GN provide a way to manage dependencies,
but GRIT also does a bunch of other stuff that make sense only for prod, and not
for tests (bundling files together, gzipping). On top of that, we already use GN
to manage test dependencies, see for example [1], where some JS files that are
needed by tests are added in the |data| section to ensure they are available
during testing, and [2] where those files are included in the test from C++.

[1]
https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=chrome/test/BUILD...
[2]
https://cs.chromium.org/chromium/src/chrome/test/base/v8_unit_test.cc?type=cs...

[Lei Zhang, 2017-06-24 01:29:29]

lgtm

I just wanted to explorer the problem space and see if it makes sense to do this
any other way.

[Lei Zhang, 2017-06-24 04:48:05]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-06-24 04:48:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 07:19:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498279685124870,
"parent_rev": "ee38108eb7f7b2a6c3cde8ba22fb331912e55106", "commit_rev":
"4bf10fb33e766df1ec8071c27cfb5a13dd7edc88"}

[commit-bot: I haz the power, 2017-06-24 07:19:58]

Description was changed from

==========
PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

This is in preparation of removing Polymer's testing related files from
the production binary.

BUG=736124
==========

to

==========
PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

This is in preparation of removing Polymer's testing related files from
the production binary.

BUG=736124

Review-Url: https://codereview.chromium.org/2949883006
Cr-Commit-Position: refs/heads/master@{#482144}
Committed:
https://chromium.googlesource.com/chromium/src/+/4bf10fb33e766df1ec8071c27cfb...
==========

[commit-bot: I haz the power, 2017-06-24 07:19:59]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4bf10fb33e766df1ec8071c27cfb...