Updating VS 2015 package with no vctip.exe

Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.468 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
Review-Url: https://codereview.chromium.org/2950223002
Cr-Commit-Position: refs/heads/master@{#481586}
Committed: https://chromium.googlesource.com/chromium/src/+/48c3f86f33b07d26c075b502ef6d0ba063c74bf3

[brucedawson, 2017-06-21 23:42:39]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 23:43:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-06-22 00:24:46]

Description was changed from

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468.

BUG=735226
==========

to

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.0 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

[brucedawson, 2017-06-22 00:24:46]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2017-06-22 01:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 01:49:41]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-06-22 17:09:50]

Description was changed from

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.0 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

to

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.0 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

[brucedawson, 2017-06-22 17:10:10]

Description was changed from

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.0 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

to

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.0 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

[brucedawson, 2017-06-22 17:12:25]

This time it really is the last VS 2015 package! (and the fixed SDK worked).
PTAL.

[scottmg, 2017-06-22 17:19:12]

15063.468 in the cl description, not .0, right?

lgtm

[brucedawson, 2017-06-22 17:20:39]

On 2017/06/22 17:19:12, scottmg wrote:
> 15063.468 in the cl description, not .0, right?
> 
> lgtm

Yes, it's 15063.468 - second or third patch of 15063. Are you saying that should
be added to the CL description?

[scottmg, 2017-06-22 17:23:53]

On 2017/06/22 17:20:39, brucedawson wrote:
> On 2017/06/22 17:19:12, scottmg wrote:
> > 15063.468 in the cl description, not .0, right?
> > 
> > lgtm
> 
> Yes, it's 15063.468 - second or third patch of 15063. Are you saying that
should
> be added to the CL description?

Just a couple refs there say .0. Or is it still in that folder? No biggie either
way.

"""
  python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0
"""

[brucedawson, 2017-06-22 17:28:09]

Description was changed from

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.0 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

to

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.468 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

[brucedawson, 2017-06-22 17:29:54]

> Just a couple refs there say .0. Or is it still in that folder? No biggie
either
> way.

Ah - I understand. I fixed one of the references (the SDK that I installed) to
say .468. The other ones need to stay at .0 because that is what the folder name
is. It's not clear why they put the trailing zero in the folder name given that
they never use it.

Now the inconsistency in the CL description is perfectly logical.

[brucedawson, 2017-06-22 17:30:45]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-06-22 17:31:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-06-22 17:38:38]

On 2017/06/22 17:29:54, brucedawson wrote:
> > Just a couple refs there say .0. Or is it still in that folder? No biggie
> either
> > way.
> 
> Ah - I understand. I fixed one of the references (the SDK that I installed) to
> say .468. The other ones need to stay at .0 because that is what the folder
name
> is. It's not clear why they put the trailing zero in the folder name given
that
> they never use it.
> 
> Now the inconsistency in the CL description is perfectly logical.

Perrrrrfect.

[commit-bot: I haz the power, 2017-06-22 17:40:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498152645880960, "parent_rev":
"fdf9b7412cc52402456000ba9553eb4064c8d096", "commit_rev":
"48c3f86f33b07d26c075b502ef6d0ba063c74bf3"}

[commit-bot: I haz the power, 2017-06-22 17:40:59]

Description was changed from

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.468 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226
==========

to

==========
Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools
(1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.468 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG=735226

Review-Url: https://codereview.chromium.org/2950223002
Cr-Commit-Position: refs/heads/master@{#481586}
Committed:
https://chromium.googlesource.com/chromium/src/+/48c3f86f33b07d26c075b502ef6d...
==========

[commit-bot: I haz the power, 2017-06-22 17:41:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48c3f86f33b07d26c075b502ef6d...