Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2950283002:
Make UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 5 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree
This patch makes |UpdateSelectionForMouseDownDispatchingSelectStart()| in
|SelectionController| class to take |SelectionInFlatTree| to reduce usage of
|VisibleSelection| for improving code health.
BUG=692923
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2950283002
Cr-Commit-Position: refs/heads/master@{#482499}
Committed: https://chromium.googlesource.com/chromium/src/+/47e7201e24fc08e37f0680f96b21bcbeff37230c
Patch Set 1 : 2017-06-22T18:21:18 #Patch Set 2 : 2017-06-26T17:37:56 Rebase #
Messages
Total messages: 28 (19 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-22T17:48:06 2017-06-22T17:48:01 BUG= 2017-06-22T17:20:52 ========== to ========== Make UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree This patch makes |UpdateSelectionForMouseDownDispatchingSelectStart()| in |SelectionController| class to take |SelectionInFlatTree| as a preparation of getting rid of granularity from selection[1]. [1] http://crbug.com/692923 Get rid of m_granularity from VisibleSelection and SelectionTemplate BUG=692923 TEST=n/a; no behavior changes ==========
Patchset #1 (id:1) has been deleted
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The change to ExpandSelectionToRespectUserSelectAll seems orthogonal. Could you split it to another patch?
On 2017/06/22 at 18:28:03, xiaochengh wrote: > The change to ExpandSelectionToRespectUserSelectAll seems orthogonal. > > Could you split it to another patch? Move changes of ExpandSelectionToRespectUserSelectAll() to http://crrev.com/2951353003
Sorry I'm confused. Does this patch depend on http://crrev.com/2951353003?
On 2017/06/23 at 17:45:08, xiaochengh wrote: > Sorry I'm confused. > > Does this patch depend on http://crrev.com/2951353003? No. You're right. I updated a description of http://crrev.com/2951353003
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree This patch makes |UpdateSelectionForMouseDownDispatchingSelectStart()| in |SelectionController| class to take |SelectionInFlatTree| as a preparation of getting rid of granularity from selection[1]. [1] http://crbug.com/692923 Get rid of m_granularity from VisibleSelection and SelectionTemplate BUG=692923 TEST=n/a; no behavior changes ========== to ========== Make UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree This patch makes |UpdateSelectionForMouseDownDispatchingSelectStart()| in |SelectionController| class to take |SelectionInFlatTree| to reduce usage of |VisibleSelection| for improving code health. BUG=692923 TEST=n/a; no behavior changes ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498526152285620,
"parent_rev": "5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377", "commit_rev":
"f9d7d61c06f1bbff1b5ca9929ba5ba985360a906"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498526152285620,
"parent_rev": "7f57698751380deb9b0daa15b0de78b89f0c063e", "commit_rev":
"28ac5d99d483531c8a0fae4419ce4a397b35cc86"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498526152285620,
"parent_rev": "3792a8c94b5a453a747f11ab82c49403c34249bd", "commit_rev":
"47e7201e24fc08e37f0680f96b21bcbeff37230c"}
Message was sent while issue was closed.
Description was changed from ========== Make UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree This patch makes |UpdateSelectionForMouseDownDispatchingSelectStart()| in |SelectionController| class to take |SelectionInFlatTree| to reduce usage of |VisibleSelection| for improving code health. BUG=692923 TEST=n/a; no behavior changes ========== to ========== Make UpdateSelectionForMouseDownDispatchingSelectStart() to take SelectionInFlatTree This patch makes |UpdateSelectionForMouseDownDispatchingSelectStart()| in |SelectionController| class to take |SelectionInFlatTree| to reduce usage of |VisibleSelection| for improving code health. BUG=692923 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2950283002 Cr-Commit-Position: refs/heads/master@{#482499} Committed: https://chromium.googlesource.com/chromium/src/+/47e7201e24fc08e37f0680f96b21... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/47e7201e24fc08e37f0680f96b21... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
