Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Issue 2952223002: Remove the speical case that we don't push mojom.js data deps to device on Android. (Closed)

Created:
3 years, 6 months ago by yzshen1
Modified:
3 years, 6 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the speical case that we don't push mojom.js data deps to device on Android. The mojom("foo") GN template now only marks generated mojom.js files as data deps for the "foo_js_data_deps" target. So it is no longer an issue. For example, now $grep '\.mojom\.js' out/Debug/gen/content/test/content_unittests_apk.native.runtimedeps | wc -l 2 (The two mojom.js files are from //mojo/public/js/bindings, which is going to be removed soon.) BUG=603212 Review-Url: https://codereview.chromium.org/2952223002 Cr-Commit-Position: refs/heads/master@{#481623} Committed: https://chromium.googlesource.com/chromium/src/+/c8b216bbd914a0e91b66d13b2030735c2ee2d964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/android/pylib/utils/device_dependencies.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
yzshen1
Hi, Would you please take a look? Thanks!
3 years, 6 months ago (2017-06-22 17:46:09 UTC) #4
agrieve
On 2017/06/22 17:46:09, yzshen1 wrote: > Hi, > > Would you please take a look? ...
3 years, 6 months ago (2017-06-22 18:10:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952223002/1
3 years, 6 months ago (2017-06-22 18:15:34 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 19:22:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c8b216bbd914a0e91b66d13b2030...

Powered by Google App Engine
This is Rietveld 408576698