Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2952233002: Fix hints and clean-up obsolete comment syntax (TBR) (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix hints and clean-up obsolete comment syntax (TBR) Committed: https://github.com/dart-lang/sdk/commit/ec8505fc794c1c4750d4956ce7e259e7cb33da64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -43 lines) Patch
M pkg/analysis_server/lib/src/collections.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +0 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol/protocol_internal.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/tool/instrumentation/page/stats_page.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-22 17:59:15 UTC) #2
Brian Wilkerson
Committed patchset #1 (id:1) manually as ec8505fc794c1c4750d4956ce7e259e7cb33da64 (presubmit successful).
3 years, 6 months ago (2017-06-22 17:59:31 UTC) #4
pquitslund
3 years, 6 months ago (2017-06-22 18:03:08 UTC) #5
Message was sent while issue was closed.
LGTM; thanks!

Powered by Google App Engine
This is Rietveld 408576698