Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2883)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/BUILD.gn

Issue 2952243002: Break up chrome/common:common
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 03da473c3e2de6a27135cefda710cfbc45a1b1c3..6718c45ae3e2996be0775fbe4c7dd335ff934e47 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -92,11 +92,89 @@ source_set("common_param_traits_macros") {
]
}
+source_set("logging_chrome") {
+ sources = [
+ "all_messages.h",
+ "chrome_utility_messages.h",
+ "common_message_generator.cc",
+ "common_message_generator.h",
+ "instant_struct_traits.h",
+ "logging_chrome.cc",
+ "logging_chrome.h",
+ "media/webrtc_logging_message_data.cc",
+ "media/webrtc_logging_message_data.h",
+ "media/webrtc_logging_messages.h",
+ "prerender_messages.h",
+ "prerender_types.h",
+ "render_messages.h",
+ "tts_messages.h",
+ "tts_utterance_request.cc",
+ "tts_utterance_request.h",
+ "web_application_info.cc",
+ "web_application_info.h",
+ ]
+ deps = [
+ ":common_param_traits_macros",
+ ":constants",
+ "//base",
+ "//chrome/common/extensions",
+ "//chrome/common/page_load_metrics",
+ "//chrome/common/search",
+ "//chrome/install_static:install_static_util",
+ "//components/ntp_tiles",
+ "//components/omnibox/common",
+ "//content/public/common",
+ "//ipc:ipc_features",
+ ]
+ if (enable_extensions) {
+ sources += [
+ "cast_messages.cc",
+ "cast_messages.h",
+ ]
+ deps += [
+ "//media/cast:common",
+ "//media/cast:net",
+ ]
+ }
+ if (enable_basic_printing || enable_print_preview) {
+ sources += [ "chrome_utility_printing_messages.h" ]
+
+ deps += [
+ "//chrome/common/cloud_print",
+ "//components/printing/common",
+ "//printing",
+ ]
+
+ if (enable_print_preview) {
+ sources += [ "service_messages.h" ]
+ }
+ }
+ if (enable_nacl) {
+ deps += [ "//components/nacl/common:minimal" ]
+ }
+ if (safe_browsing_mode != 0) {
+ deps += [ "//chrome/common/safe_browsing" ]
+ }
+}
+
+source_set("url_constants") {
+ sources = [
+ "url_constants.cc",
+ "url_constants.h",
+ ]
+ deps = [
+ ":features",
+ "//base",
+ "//content/public/common",
+ "//extensions/features",
+ "//printing/features",
+ ]
+}
+
# Use a static library here because many test binaries depend on this but don't
# require many files from it. This makes linking more efficient.
static_library("common") {
sources = [
- "all_messages.h",
"attrition_experiments.h",
"auto_start_linux.cc",
"auto_start_linux.h",
@@ -107,9 +185,6 @@ static_library("common") {
"chrome_content_client_constants.cc",
"chrome_isolated_world_ids.h",
"chrome_result_codes.h",
- "chrome_utility_messages.h",
- "common_message_generator.cc",
- "common_message_generator.h",
"common_param_traits.cc",
"common_param_traits.h",
"component_flash_hint_file_linux.cc",
@@ -122,9 +197,6 @@ static_library("common") {
"custom_handlers/protocol_handler.cc",
"custom_handlers/protocol_handler.h",
"descriptors_android.h",
- "instant_struct_traits.h",
- "logging_chrome.cc",
- "logging_chrome.h",
"mac/app_shim_launch.h",
"mac/app_shim_messages.h",
"mac/cfbundle_blocker.h",
@@ -133,26 +205,12 @@ static_library("common") {
"mac/launchd.mm",
"media/media_resource_provider.cc",
"media/media_resource_provider.h",
- "media/webrtc_logging_message_data.cc",
- "media/webrtc_logging_message_data.h",
- "media/webrtc_logging_messages.h",
- "media_galleries/metadata_types.h",
"multi_process_lock.h",
"multi_process_lock_linux.cc",
"multi_process_lock_mac.cc",
"multi_process_lock_win.cc",
"origin_trials/chrome_origin_trial_policy.cc",
"origin_trials/chrome_origin_trial_policy.h",
- "page_load_metrics/page_load_metrics_constants.h",
- "page_load_metrics/page_load_metrics_messages.h",
- "page_load_metrics/page_load_metrics_param_traits.cc",
- "page_load_metrics/page_load_metrics_param_traits.h",
- "page_load_metrics/page_load_metrics_util.cc",
- "page_load_metrics/page_load_metrics_util.h",
- "page_load_metrics/page_load_timing.cc",
- "page_load_metrics/page_load_timing.h",
- "page_load_metrics/page_track_decider.cc",
- "page_load_metrics/page_track_decider.h",
"partial_circular_buffer.cc",
"partial_circular_buffer.h",
"pause_tabs_field_trial.h",
@@ -160,20 +218,11 @@ static_library("common") {
"pdf_uma.h",
"pref_names_util.cc",
"pref_names_util.h",
- "prerender_messages.h",
- "prerender_types.h",
"profiling.cc",
"profiling.h",
"ref_counted_util.h",
- "render_messages.h",
"resource_usage_reporter_type_converters.cc",
"resource_usage_reporter_type_converters.h",
- "search/instant_types.cc",
- "search/instant_types.h",
- "search/ntp_logging_events.h",
- "search/search_types.h",
- "search/search_urls.cc",
- "search/search_urls.h",
"secure_origin_whitelist.cc",
"secure_origin_whitelist.h",
"ssl_insecure_content.cc",
@@ -184,13 +233,6 @@ static_library("common") {
"switch_utils.h",
"trace_event_args_whitelist.cc",
"trace_event_args_whitelist.h",
- "tts_messages.h",
- "tts_utterance_request.cc",
- "tts_utterance_request.h",
- "url_constants.cc",
- "url_constants.h",
- "web_application_info.cc",
- "web_application_info.h",
]
defines = []
@@ -204,8 +246,9 @@ static_library("common") {
":common_param_traits_macros",
":features",
":ini_parser",
+ ":logging_chrome",
":mojo_bindings",
- ":page_load_metrics_mojom",
+ ":url_constants",
"//base:base",
"//base:base_static",
"//base:i18n",
@@ -215,7 +258,10 @@ static_library("common") {
"//chrome/common:constants",
"//chrome/common/media_router/mojo:dial_utility_interfaces",
"//chrome/common/net",
+ "//chrome/common/page_load_metrics",
+ "//chrome/common/page_load_metrics:page_load_metrics_mojom",
"//chrome/common/profiling",
+ "//chrome/common/search",
"//chrome/installer/util:with_no_strings",
"//components/cast_certificate",
"//components/cdm/common",
@@ -240,7 +286,6 @@ static_library("common") {
"//components/password_manager/content/common:mojo_interfaces",
"//components/password_manager/core/common",
"//components/policy:generated",
- "//components/policy/core/common",
"//components/prefs",
"//components/signin/core/common",
"//components/signin/core/common:signin_features",
@@ -274,7 +319,6 @@ static_library("common") {
"//ui/gfx/ipc/geometry",
"//ui/gfx/ipc/skia",
"//ui/gl",
- "//ui/message_center",
"//ui/resources:resources",
"//url",
]
@@ -284,118 +328,9 @@ static_library("common") {
}
if (enable_extensions) {
- sources += [
- "cast_messages.cc",
- "cast_messages.h",
- "extensions/api/automation_api_constants.h",
- "extensions/api/commands/commands_handler.cc",
- "extensions/api/commands/commands_handler.h",
- "extensions/api/extension_action/action_info.cc",
- "extensions/api/extension_action/action_info.h",
- "extensions/api/notifications/notification_style.cc",
- "extensions/api/notifications/notification_style.h",
- "extensions/api/omnibox/omnibox_handler.cc",
- "extensions/api/omnibox/omnibox_handler.h",
- "extensions/api/speech/tts_engine_manifest_handler.cc",
- "extensions/api/speech/tts_engine_manifest_handler.h",
- "extensions/api/spellcheck/spellcheck_handler.cc",
- "extensions/api/spellcheck/spellcheck_handler.h",
- "extensions/api/storage/storage_schema_manifest_handler.cc",
- "extensions/api/storage/storage_schema_manifest_handler.h",
- "extensions/api/system_indicator/system_indicator_handler.cc",
- "extensions/api/system_indicator/system_indicator_handler.h",
- "extensions/api/url_handlers/url_handlers_parser.cc",
- "extensions/api/url_handlers/url_handlers_parser.h",
- "extensions/api/webstore/webstore_api_constants.cc",
- "extensions/api/webstore/webstore_api_constants.h",
- "extensions/chrome_aliases.cc",
- "extensions/chrome_aliases.h",
- "extensions/chrome_extension_messages.h",
- "extensions/chrome_extensions_client.cc",
- "extensions/chrome_extensions_client.h",
- "extensions/chrome_manifest_handlers.cc",
- "extensions/chrome_manifest_handlers.h",
- "extensions/chrome_manifest_url_handlers.cc",
- "extensions/chrome_manifest_url_handlers.h",
- "extensions/chrome_utility_extensions_messages.h",
- "extensions/command.cc",
- "extensions/command.h",
- "extensions/extension_constants.cc",
- "extensions/extension_constants.h",
- "extensions/extension_metrics.cc",
- "extensions/extension_metrics.h",
- "extensions/extension_process_policy.cc",
- "extensions/extension_process_policy.h",
- "extensions/image_writer/image_writer_util_mac.cc",
- "extensions/image_writer/image_writer_util_mac.h",
- "extensions/manifest_handlers/app_icon_color_info.cc",
- "extensions/manifest_handlers/app_icon_color_info.h",
- "extensions/manifest_handlers/app_launch_info.cc",
- "extensions/manifest_handlers/app_launch_info.h",
- "extensions/manifest_handlers/automation.cc",
- "extensions/manifest_handlers/automation.h",
- "extensions/manifest_handlers/content_scripts_handler.cc",
- "extensions/manifest_handlers/content_scripts_handler.h",
- "extensions/manifest_handlers/extension_action_handler.cc",
- "extensions/manifest_handlers/extension_action_handler.h",
- "extensions/manifest_handlers/linked_app_icons.cc",
- "extensions/manifest_handlers/linked_app_icons.h",
- "extensions/manifest_handlers/minimum_chrome_version_checker.cc",
- "extensions/manifest_handlers/minimum_chrome_version_checker.h",
- "extensions/manifest_handlers/settings_overrides_handler.cc",
- "extensions/manifest_handlers/settings_overrides_handler.h",
- "extensions/manifest_handlers/theme_handler.cc",
- "extensions/manifest_handlers/theme_handler.h",
- "extensions/manifest_handlers/ui_overrides_handler.cc",
- "extensions/manifest_handlers/ui_overrides_handler.h",
- "extensions/mojom/inline_install_traits.h",
- "extensions/permissions/chrome_api_permissions.cc",
- "extensions/permissions/chrome_api_permissions.h",
- "extensions/permissions/chrome_permission_message_provider.cc",
- "extensions/permissions/chrome_permission_message_provider.h",
- "extensions/permissions/chrome_permission_message_rules.cc",
- "extensions/permissions/chrome_permission_message_rules.h",
- "extensions/sync_helper.cc",
- "extensions/sync_helper.h",
- "extensions/webstore_install_result.cc",
- "extensions/webstore_install_result.h",
- ]
- public_deps += [
- "//chrome/common/extensions:mojo_bindings",
- "//chrome/common/extensions/api",
- "//chrome/common/extensions/api:extensions_features",
- "//device/usb",
- "//extensions:extensions_resources",
- "//extensions/common",
- "//extensions/common/api",
- "//extensions/strings",
- "//media/cast:net",
- ]
- if (is_chromeos) {
- sources += [
- "extensions/api/file_browser_handlers/file_browser_handler.cc",
- "extensions/api/file_browser_handlers/file_browser_handler.h",
- "extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc",
- "extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h",
- "extensions/api/input_ime/input_components_handler.cc",
- "extensions/api/input_ime/input_components_handler.h",
- ]
- }
- if (use_aura) {
- # This dependency is for a header used only by extensions code.
- public_deps += [ "//ui/keyboard:keyboard_with_content" ]
- }
+ public_deps += [ "//chrome/common/extensions" ]
}
- if (is_win || is_mac) {
- sources += [
- "media_galleries/itunes_library.cc",
- "media_galleries/itunes_library.h",
- "media_galleries/picasa_types.cc",
- "media_galleries/picasa_types.h",
- "media_galleries/pmp_constants.h",
- ]
- }
if (is_mac) {
public_deps += [ ":app_mode_app_support" ]
}
@@ -409,17 +344,9 @@ static_library("common") {
# Printing.
if (enable_basic_printing || enable_print_preview) {
- sources += [ "chrome_utility_printing_messages.h" ]
-
- public_deps += [
- "//chrome/common/cloud_print",
- "//components/printing/common",
- "//printing",
- ]
if (enable_print_preview) {
# Full printing support.
sources += [
- "service_messages.h",
"service_process_util.cc",
"service_process_util.h",
"service_process_util_linux.cc",
@@ -432,7 +359,6 @@ static_library("common") {
}
if (is_android) {
- sources -= [ "media_galleries/metadata_types.h" ]
sources += [
"media/chrome_media_drm_bridge_client.cc",
"media/chrome_media_drm_bridge_client.h",
@@ -700,13 +626,3 @@ mojom("instant_mojom") {
"//url/mojo:url_mojom_gurl",
]
}
-
-mojom("page_load_metrics_mojom") {
- sources = [
- "page_load_metrics/page_load_metrics.mojom",
- ]
-
- public_deps = [
- "//mojo/common:common_custom_types",
- ]
-}
« no previous file with comments | « no previous file | chrome/common/extensions/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698