Issue 2952243002: Break up chrome/common:common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2952243002: Break up chrome/common:common

Created:
3 years, 6 months ago by manzagop (departed)

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews, extensions-reviews_chromium.org, tommycli, Lei Zhang, speed-metrics-reviews_chromium.org, loading-reviews+metrics_chromium.org, csharrison+watch_chromium.org, chromium-apps-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Break up chrome/common:common This CL breaks off some targets from chrome/common:common. Context: https://crrev.com/2850863002 introduced a binary size regression. In order to address it, chrome_logging.* needs to be pulled out from chrome/common:common to a separate target, but this turns out to be hard. This CL is a stepping stone. BUG=717103

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+283 lines, -170 lines)			Patch
M	chrome/common/BUILD.gn	View	14 chunks	+85 lines, -169 lines	0 comments	Download
M	chrome/common/extensions/BUILD.gn	View	2 chunks	+113 lines, -0 lines	0 comments	Download
A	chrome/common/media_galleries/BUILD.gn	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	chrome/common/page_load_metrics/BUILD.gn	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	chrome/common/search/BUILD.gn	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/utility/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download