Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2952433002: Fix tab presentation metrics (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/stack_view/stack_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 1beacd5bfcf280a37bc1afa71678e7b0c02942bd..e7b12f656e8b54507f709484da1928be5cdc2d6a 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -1639,6 +1639,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
if (self.foregroundTabWasAddedCompletionBlock) {
self.foregroundTabWasAddedCompletionBlock();
+ self.foregroundTabWasAddedCompletionBlock = nil;
}
});
} else {
@@ -1677,10 +1678,11 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
[topTab updateSnapshotWithOverlay:YES visibleFrameOnly:YES];
startVoiceSearchIfNecessaryBlock();
});
+ // Reset the foreground tab completion block so that it can never be
+ // called more than once regardless of foreground/background tab
+ // appearances.
+ self.foregroundTabWasAddedCompletionBlock = nil;
}
- // Reset the foreground tab completion block so that it can never be
- // called more than once regardless of foreground/background tab appearances.
- self.foregroundTabWasAddedCompletionBlock = nil;
}
#pragma mark - UI Configuration and Layout
« no previous file with comments | « no previous file | ios/chrome/browser/ui/stack_view/stack_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698