Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2952433002: Fix tab presentation metrics (Closed)

Created:
3 years, 6 months ago by PL
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tab presentation metrics BUG=724682 Review-Url: https://codereview.chromium.org/2952433002 Cr-Commit-Position: refs/heads/master@{#481590} Committed: https://chromium.googlesource.com/chromium/src/+/9f1b6e0775d4a97df66d39197df9c6a01a41539b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
PL
Hi Rohit, I made some errors with the initial implementation of this metric, a typo ...
3 years, 6 months ago (2017-06-20 00:17:16 UTC) #2
rohitrao (ping after 24h)
lgtm Sorry, I looked at this yesterday and then never hit send.
3 years, 6 months ago (2017-06-21 01:02:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952433002/1
3 years, 6 months ago (2017-06-22 17:34:38 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 17:47:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f1b6e0775d4a97df66d39197df9...

Powered by Google App Engine
This is Rietveld 408576698