Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2952973002: Introduce VisibleSelection::CreateWithoutValidationDeprecated() (Closed)
Patch Set: 2017-06-23T09:54:35 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index 11a85d062b961274345968ba76425487819348b6..d9a827dcf4b800a8f0a612bd2377108f18bce962 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -125,8 +125,14 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
bool IsContentRichlyEditable() const;
bool IsValidFor(const Document&) const;
- void SetWithoutValidation(const PositionTemplate<Strategy>&,
- const PositionTemplate<Strategy>&);
+
+ // TODO(editing-dev): |CreateWithoutValidationDeprecated()| is allowed
+ // only to use in |TypingCommand| to remove part of grapheme cluster.
+ // Note: |base| and |extent| can be disconnect position.
+ static VisibleSelectionTemplate<Strategy> CreateWithoutValidationDeprecated(
+ const PositionTemplate<Strategy>& base,
+ const PositionTemplate<Strategy>& extent,
+ TextAffinity);
DECLARE_TRACE();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698