Introduce VisibleSelection::CreateWithoutValidationDeprecated()

Introduce VisibleSelection::CreateWithoutValidationDeprecated()

This patch introduces |VisibleSelection::CreateWithoutValidationDeprecated()|
as replacement of |SetWithoutValidation()| to make |VisibleSelection| as
virtually immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952973002
Cr-Commit-Position: refs/heads/master@{#481799}
Committed: https://chromium.googlesource.com/chromium/src/+/f7e272242d8becf099d77d7b222afad07286401d

[yosin_UTC9, 2017-06-22 04:37:14]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 04:37:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-22 06:16:08]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 06:16:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 07:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 07:59:08]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-22 08:05:32]

Description was changed from

==========
2017-06-22T13:35:38

BUG=660320

2017-06-22T13:35:34
==========

to

==========
Introduce VisibleSelection::CreateWithoutValidationDeprecated()

This patch introduces |VisibleSelection::CreateWithoutValidationDeprecated()|
as replacement of |SetWithoutValidation()| to make |VisibleSelection| as
virtually immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-22 08:05:56]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-22 08:05:57]

PTAL

[Xiaocheng, 2017-06-22 18:20:10]

lgtm

https://codereview.chromium.org/2952973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleSelection.cpp (right):

https://codereview.chromium.org/2952973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:500: // Since
|m_affinity| for non-|CaretSelection| is always |Downstream|,
nits:
s/m_affinity/affinity/
s/Downstream/kDownstream/

https://codereview.chromium.org/2952973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:502: // |m_affinity|
is |TextAffinity::Upstream|.
nits:
s/m_affinity/affinity/
s/Upstream/kUpstream/

[yosin_UTC9, 2017-06-23 00:57:32]

Thanks for reviewing!

Committing...

https://codereview.chromium.org/2952973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleSelection.cpp (right):

https://codereview.chromium.org/2952973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:500: // Since
|m_affinity| for non-|CaretSelection| is always |Downstream|,
On 2017/06/22 at 18:20:10, Xiaocheng wrote:
> nits:
> s/m_affinity/affinity/
> s/Downstream/kDownstream/

Done.

https://codereview.chromium.org/2952973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:502: // |m_affinity|
is |TextAffinity::Upstream|.
On 2017/06/22 at 18:20:10, Xiaocheng wrote:
> nits:
> s/m_affinity/affinity/
> s/Upstream/kUpstream/

Done.

[yosin_UTC9, 2017-06-23 01:03:29]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-06-23 01:03:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2952973002/#ps40001
(title: "2017-06-23T09:54:35")

[commit-bot: I haz the power, 2017-06-23 01:03:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:11:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498179809129790,
"parent_rev": "fd73d906631e01ab8fdd64f8c7ad9f0cc46d6767", "commit_rev":
"f75f281f72b1a412804025bf1b1d8919974c6bab"}

[commit-bot: I haz the power, 2017-06-23 03:12:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498179809129790,
"parent_rev": "1e2af45880feed8efbd62ded35f05ec6be4b4f59", "commit_rev":
"f7e272242d8becf099d77d7b222afad07286401d"}

[commit-bot: I haz the power, 2017-06-23 03:12:11]

Description was changed from

==========
Introduce VisibleSelection::CreateWithoutValidationDeprecated()

This patch introduces |VisibleSelection::CreateWithoutValidationDeprecated()|
as replacement of |SetWithoutValidation()| to make |VisibleSelection| as
virtually immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Introduce VisibleSelection::CreateWithoutValidationDeprecated()

This patch introduces |VisibleSelection::CreateWithoutValidationDeprecated()|
as replacement of |SetWithoutValidation()| to make |VisibleSelection| as
virtually immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952973002
Cr-Commit-Position: refs/heads/master@{#481799}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7e272242d8becf099d77d7b222a...
==========

[commit-bot: I haz the power, 2017-06-23 03:12:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7e272242d8becf099d77d7b222a...