Settings: Network: Support choose mobile network

Settings: Network: Support choose mobile network

This also removes the no longer used 'secondary-button' class from internet_detail_page.

BUG=735844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956433003
Cr-Commit-Position: refs/heads/master@{#482703}
Committed: https://chromium.googlesource.com/chromium/src/+/025ffc69799a04084936d4edfdf57bc6ef28a93f

[stevenjb, 2017-06-22 17:58:05]

Description was changed from

==========
Settings: Network: Support choose mobile network

BUG=735844
==========

to

==========
Settings: Network: Support choose mobile network

BUG=735844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-06-22 18:03:59]

Description was changed from

==========
Settings: Network: Support choose mobile network

BUG=735844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Network: Support choose mobile network

This also removes the no longer used 'secondary-button' class from
internet_detail_page.

BUG=735844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-06-22 18:16:55]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2017-06-22 18:23:43]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2017-06-22 18:54:50]

https://codereview.chromium.org/2956433003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2956433003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:621:
chrome.send('addNetwork', [this.networkProperties.Type]);
Drive by comment. Can you put chrome.send calls behind a proxy? This is the
pattern we used across Settings and makes testing much easier. Assuming
internet_detail_page has no tests, but that does not mean we should break our
JS/C++ browser proxy pattern here.

[stevenjb, 2017-06-22 19:51:37]

https://codereview.chromium.org/2956433003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2956433003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:621:
chrome.send('addNetwork', [this.networkProperties.Type]);
On 2017/06/22 18:54:50, dpapad wrote:
> Drive by comment. Can you put chrome.send calls behind a proxy? This is the
> pattern we used across Settings and makes testing much easier. Assuming
> internet_detail_page has no tests, but that does not mean we should break our
> JS/C++ browser proxy pattern here. 

No, it's not worth it, they will all be deprecated, thus the comment. I'm aware
of the pattern, I suggested it originally :)

[michaelpg, 2017-06-23 22:30:21]

lgtm

[stevenjb, 2017-06-26 17:15:56]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-06-26 17:16:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 17:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 17:18:19]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[stevenjb, 2017-06-27 17:43:01]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-06-27 17:43:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2956433003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-27 17:43:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 19:12:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498585381734840,
"parent_rev": "0524e2048b04ec3f86325e112cb91ac2c439e582", "commit_rev":
"025ffc69799a04084936d4edfdf57bc6ef28a93f"}

[commit-bot: I haz the power, 2017-06-27 19:12:58]

Description was changed from

==========
Settings: Network: Support choose mobile network

This also removes the no longer used 'secondary-button' class from
internet_detail_page.

BUG=735844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Network: Support choose mobile network

This also removes the no longer used 'secondary-button' class from
internet_detail_page.

BUG=735844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956433003
Cr-Commit-Position: refs/heads/master@{#482703}
Committed:
https://chromium.googlesource.com/chromium/src/+/025ffc69799a04084936d4edfdf5...
==========

[commit-bot: I haz the power, 2017-06-27 19:12:59]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/025ffc69799a04084936d4edfdf5...