Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Issue 2956463002: Convert the mouse exit only use for update UI hover state to mouse move (Closed)

Created:
3 years, 6 months ago by chaopeng
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert the mouse exit only use for update UI hover state to mouse move This issue caused by: 1. On CrOS, we disappear the mouse cursor when keyboard keydown. This is only on Mac and CrOS for chrome. 2. On CrOS, we disappear the mouse cursor when touch. 3. 450edc67348bc0106da16e56d783b2c3c9a9030c introduced mouse exit event to update Browser UI hover state when mouse cursor hide. 4. We have a bug for overlay scrollbar because we convert mouse exit to mouse move so we can not fade out the scrollbars we mouse move out of window. Then we convert mouse exit as a mouse leave. 5. After 3 and 4, the mouse hide in 1 will send a mouse leave to js which the popup-div listening and disappear the popup. In this patch we add a flag to the mouse exit event introduced at (3) and convert that to MouseMove as the behavior before (4) so it will not send out a mouseleave and not change the document hover state. BUG=723535

Patch Set 1 : delete test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M ui/aura/window_event_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/event.h View 4 chunks +14 lines, -2 lines 0 comments Download
M ui/events/event.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (11 generated)
chaopeng
Description was changed from ========== Filter the mouse exit event that CrOS only use for ...
3 years, 6 months ago (2017-06-22 18:19:28 UTC) #1
chaopeng
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-22 18:19:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956463002/1
3 years, 6 months ago (2017-06-22 18:20:05 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-22 21:36:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-22 21:36:56 UTC) #5
chaopeng
Patchset #2 (id:20001) has been deleted
3 years, 6 months ago (2017-06-23 01:56:39 UTC) #6
chaopeng
Patchset #1 (id:1) has been deleted
3 years, 6 months ago (2017-06-23 01:57:28 UTC) #7
chaopeng
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-23 01:57:32 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956463002/40001
3 years, 6 months ago (2017-06-23 01:57:52 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-23 02:15:54 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 02:15:55 UTC) #11
Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

Powered by Google App Engine
This is Rietveld 408576698