Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2993403002: Support a user-provided string for the TLS ALPN extension.

Created:
3 years, 4 months ago by diogor
Modified:
3 years, 3 months ago
Reviewers:
emadomara1
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Support a user-provided string for the TLS ALPN extension. Fix source formatting Add TLS ALPN extension. BUG=webrtc:8086

Patch Set 1 #

Patch Set 2 : Fix source formatting #

Patch Set 3 : Address most comments #

Patch Set 4 : Fix objc naming #

Patch Set 5 : Add alpnProtocol string to initWithNativeServer #

Patch Set 6 : Remove failing unit tests. They are working as intended #

Patch Set 7 : Rename alpn_protocols and change to std::vector<std::string> #

Patch Set 8 : Rebase #

Patch Set 9 : Fix typos #

Patch Set 10 : Fix bracket in objc test #

Patch Set 11 : Fix typo in objc IceServer #

Patch Set 12 : Try passing an empty tlsAlpnProtocols array instead of nil #

Patch Set 13 : Change tls_alpn_protocols in jni to jobject #

Patch Set 14 : Try remove openssl/evp include #

Patch Set 15 : Try adding boringssl to include_dirs #

Patch Set 16 : Try adding boringssl dep #

Patch Set 17 : Try expanding PacketSocketTcpOptions init #

Patch Set 18 : Fix previous commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -35 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/p2p/base/basicpacketsocketfactory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +13 lines, -1 line 0 comments Download
M webrtc/p2p/base/basicpacketsocketfactory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +9 lines, -5 lines 0 comments Download
M webrtc/p2p/base/packetsocketfactory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +22 lines, -1 line 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/testturnserver.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnport.h View 1 2 3 4 5 6 4 chunks +10 lines, -3 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +11 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/iceserverparsing.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/rtc_base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/rtc_base/openssladapter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/rtc_base/openssladapter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 7 chunks +45 lines, -6 lines 0 comments Download
A webrtc/rtc_base/openssladapter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +42 lines, -0 lines 0 comments Download
M webrtc/rtc_base/ssladapter.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/rtc_base/ssladapter_unittest.cc View 1 2 3 4 5 6 4 chunks +17 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/PeerConnection.java View 1 2 3 4 5 6 2 chunks +10 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/pc/java_native_conversion.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +16 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCIceServer.mm View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +33 lines, -3 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceServer.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +16 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCIceServerTest.mm View 1 2 3 4 5 6 7 8 9 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 76 (76 generated)
diogor
Description was changed from ========== Support a user-provided string for the TLS ALPN extension. Fix ...
3 years, 4 months ago (2017-08-10 20:39:27 UTC) #1
diogor
diogor@google.com changed reviewers: + emadomara@webrtc.org
3 years, 4 months ago (2017-08-10 20:49:01 UTC) #2
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-14 20:10:26 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/40001
3 years, 4 months ago (2017-08-14 20:10:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-14 20:15:05 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/23852) mac_rel on ...
3 years, 4 months ago (2017-08-14 20:15:06 UTC) #6
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-14 20:26:42 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/60001
3 years, 4 months ago (2017-08-14 20:26:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-14 20:29:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/22746) ios_dbg on ...
3 years, 4 months ago (2017-08-14 20:29:55 UTC) #10
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-14 20:35:31 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/80001
3 years, 4 months ago (2017-08-14 20:35:35 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-14 20:40:44 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/28498)
3 years, 4 months ago (2017-08-14 20:40:45 UTC) #14
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-14 20:52:17 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/100001
3 years, 4 months ago (2017-08-14 20:52:25 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-14 21:43:34 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2017-08-14 21:43:35 UTC) #18
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-14 21:45:48 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/100001
3 years, 4 months ago (2017-08-14 21:45:53 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-14 21:48:36 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2017-08-14 21:48:37 UTC) #22
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-14 21:52:12 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/100001
3 years, 4 months ago (2017-08-14 21:52:24 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-14 21:56:44 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2017-08-14 21:56:45 UTC) #26
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-16 22:13:49 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/120001
3 years, 4 months ago (2017-08-16 22:13:52 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-16 22:16:22 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/builds/18256) presubmit on ...
3 years, 4 months ago (2017-08-16 22:16:23 UTC) #30
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-17 23:19:53 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/140001
3 years, 4 months ago (2017-08-17 23:19:57 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-17 23:23:26 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/22899) ios_dbg on ...
3 years, 4 months ago (2017-08-17 23:23:27 UTC) #34
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-18 00:36:54 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/160001
3 years, 4 months ago (2017-08-18 00:36:57 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-18 00:40:26 UTC) #37
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24001)
3 years, 4 months ago (2017-08-18 00:40:27 UTC) #38
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-18 17:00:01 UTC) #39
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/180001
3 years, 4 months ago (2017-08-18 17:00:09 UTC) #40
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-18 17:04:20 UTC) #41
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/25943) ios32_sim_ios9_dbg on ...
3 years, 4 months ago (2017-08-18 17:04:21 UTC) #42
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-18 17:39:38 UTC) #43
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/200001
3 years, 4 months ago (2017-08-18 17:39:41 UTC) #44
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-18 17:43:10 UTC) #45
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/builds/6922)
3 years, 4 months ago (2017-08-18 17:43:11 UTC) #46
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-18 17:53:32 UTC) #47
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/220001
3 years, 4 months ago (2017-08-18 17:53:41 UTC) #48
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-18 17:57:10 UTC) #49
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/builds/6662)
3 years, 4 months ago (2017-08-18 17:57:11 UTC) #50
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-18 18:21:28 UTC) #51
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/240001
3 years, 4 months ago (2017-08-18 18:21:31 UTC) #52
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-18 18:25:00 UTC) #53
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/27172)
3 years, 4 months ago (2017-08-18 18:25:02 UTC) #54
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 4 months ago (2017-08-18 18:34:27 UTC) #55
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/260001
3 years, 4 months ago (2017-08-18 18:34:33 UTC) #56
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-18 18:38:20 UTC) #57
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/18486) mac_rel on ...
3 years, 4 months ago (2017-08-18 18:38:21 UTC) #58
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 3 months ago (2017-08-28 21:38:50 UTC) #59
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/280001
3 years, 3 months ago (2017-08-28 21:39:00 UTC) #60
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 3 months ago (2017-08-28 21:43:09 UTC) #61
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/11940) win_x64_rel on ...
3 years, 3 months ago (2017-08-28 21:43:11 UTC) #62
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 3 months ago (2017-08-28 21:51:33 UTC) #63
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/300001
3 years, 3 months ago (2017-08-28 21:51:42 UTC) #64
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 3 months ago (2017-08-28 22:05:10 UTC) #65
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/300001
3 years, 3 months ago (2017-08-28 22:05:21 UTC) #66
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 3 months ago (2017-08-28 22:20:10 UTC) #67
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/29103)
3 years, 3 months ago (2017-08-28 22:20:11 UTC) #68
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 3 months ago (2017-08-28 22:25:44 UTC) #69
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/320001
3 years, 3 months ago (2017-08-28 22:25:51 UTC) #70
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 3 months ago (2017-08-28 22:30:45 UTC) #71
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/340001
3 years, 3 months ago (2017-08-28 22:30:50 UTC) #72
diogor
The CQ bit was checked by diogor@google.com to run a CQ dry run
3 years, 3 months ago (2017-08-28 22:41:19 UTC) #73
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993403002/340001
3 years, 3 months ago (2017-08-28 22:41:31 UTC) #74
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 3 months ago (2017-08-28 23:26:20 UTC) #75
commit-bot: I haz the power
3 years, 3 months ago (2017-08-28 23:26:21 UTC) #76
Dry run: Try jobs failed on following builders:
  linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/...)

Powered by Google App Engine
This is Rietveld 408576698