Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Issue 2994183002: Results.html: fix height of statistics table. (Closed)

Created:
3 years, 4 months ago by benjhayden
Modified:
3 years, 4 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Results.html: fix height of statistics table. Currently, when the statistics table is taller than the chart (as is often the case in non-reference columns), the entire statistics table is shown, causing blank space beneath the chart, which causes the chart to jump when the user drags to resize the chart area. This CL sets overflow-y:auto and maxHeight on the statistics table to prevent the blank space beneath the chart and so that the drag-handle is always glued to the bottom of the chart. BUG=catapult:#3382 Review-Url: https://codereview.chromium.org/2994183002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/21232f747bd10bc9c960bb42f06ed63f7e69d0b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M tracing/tracing/value/ui/histogram_span.html View 4 chunks +9 lines, -0 lines 0 comments Download
M tracing/tracing/value/ui/histogram_span_test.html View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL
3 years, 4 months ago (2017-08-13 20:25:31 UTC) #2
eakuefner
lgtm
3 years, 4 months ago (2017-08-18 23:25:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2994183002/1
3 years, 4 months ago (2017-08-19 17:25:04 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-19 18:10:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698