Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart

Issue 2995923002: Restore "Speedup Observatory elements first time rendering" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'package:unittest/unittest.dart'; 6 import 'package:unittest/unittest.dart';
7 import 'package:observatory/src/elements/curly_block.dart'; 7 import 'package:observatory/src/elements/curly_block.dart';
8 import 'package:observatory/src/elements/inbound_references.dart'; 8 import 'package:observatory/src/elements/inbound_references.dart';
9 import 'package:observatory/src/elements/instance_ref.dart'; 9 import 'package:observatory/src/elements/instance_ref.dart';
10 import '../mocks.dart'; 10 import '../mocks.dart';
(...skipping 25 matching lines...) Expand all
36 expect(i, equals(isolate)); 36 expect(i, equals(isolate));
37 expect(id, equals(object.id)); 37 expect(id, equals(object.id));
38 invoked = true; 38 invoked = true;
39 return references; 39 return references;
40 }, count: 1)); 40 }, count: 1));
41 final objects = new ObjectRepositoryMock(); 41 final objects = new ObjectRepositoryMock();
42 final e = new InboundReferencesElement(isolate, object, inbounds, objects); 42 final e = new InboundReferencesElement(isolate, object, inbounds, objects);
43 document.body.append(e); 43 document.body.append(e);
44 await e.onRendered.first; 44 await e.onRendered.first;
45 expect(invoked, isFalse); 45 expect(invoked, isFalse);
46 expect(e.children.length, isNonZero, reason: 'has elements'); 46 expect(e.children, isNotEmpty, reason: 'has elements');
47 expect(e.querySelectorAll(iTag).length, isZero); 47 expect(e.querySelectorAll(iTag).length, isZero);
48 (e.querySelector(cTag) as CurlyBlockElement).toggle(); 48 (e.querySelector(cTag) as CurlyBlockElement).toggle();
49 await e.onRendered.first; 49 await e.onRendered.first;
50 expect(invoked, isTrue); 50 expect(invoked, isTrue);
51 expect(e.querySelectorAll(iTag).length, equals(1)); 51 expect(e.querySelectorAll(iTag).length, equals(1));
52 expect(e.querySelectorAll(rTag).length, equals(1)); 52 expect(e.querySelectorAll(rTag).length, equals(1));
53 e.remove(); 53 e.remove();
54 await e.onRendered.first; 54 await e.onRendered.first;
55 expect(e.children.length, isZero, reason: 'is empty'); 55 expect(e.children, isEmpty, reason: 'is empty');
56 }); 56 });
57 } 57 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698