Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2995923002: Restore "Speedup Observatory elements first time rendering" (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore "Speedup Observatory elements first time rendering" The CurlyBlockElement was using a hack to speedup rendering to allow RetainingPathElement and InboundReferencesElement to pass the tests. - Removed hack from CurlyBlockElement - Converted RetainingPathElement and InboundReferencesElement to the waitFor APi. Related https://github.com/dart-lang/sdk/commit/7568ed5f69e384e1832757a6c27d343616626afb R=asiva@google.com, bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/b87e991af28d50a9ec6f3c2ff7afbad61c3f74e5

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
cbernaschina
3 years, 4 months ago (2017-08-15 02:03:16 UTC) #3
bkonyi
LGTM, but you might still want to have Siva take a look as well.
3 years, 4 months ago (2017-08-15 19:22:04 UTC) #4
siva
lgtm
3 years, 4 months ago (2017-08-18 23:54:02 UTC) #5
cbernaschina
3 years, 4 months ago (2017-08-19 00:09:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b87e991af28d50a9ec6f3c2ff7afbad61c3f74e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698