Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: runtime/observatory/tests/observatory_ui/objectstore_view/element_test.dart

Issue 2995923002: Restore "Speedup Observatory elements first time rendering" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'package:unittest/unittest.dart'; 6 import 'package:unittest/unittest.dart';
7 import 'package:observatory/src/elements/objectstore_view.dart'; 7 import 'package:observatory/src/elements/objectstore_view.dart';
8 import '../mocks.dart'; 8 import '../mocks.dart';
9 9
10 main() { 10 main() {
(...skipping 22 matching lines...) Expand all
33 getter: expectAsync((i) async { 33 getter: expectAsync((i) async {
34 expect(i, equals(isolate)); 34 expect(i, equals(isolate));
35 return store; 35 return store;
36 }, count: 1)); 36 }, count: 1));
37 final objects = new ObjectRepositoryMock(); 37 final objects = new ObjectRepositoryMock();
38 final e = new ObjectStoreViewElement( 38 final e = new ObjectStoreViewElement(
39 vm, isolate, events, notifs, stores, objects); 39 vm, isolate, events, notifs, stores, objects);
40 document.body.append(e); 40 document.body.append(e);
41 await e.onRendered.first; 41 await e.onRendered.first;
42 expect(e.children.length, isNonZero, reason: 'has elements'); 42 expect(e.children.length, isNonZero, reason: 'has elements');
43 await e.onRendered.first;
43 expect(e.querySelectorAll('.memberItem').length, equals(fields.length)); 44 expect(e.querySelectorAll('.memberItem').length, equals(fields.length));
44 e.remove(); 45 e.remove();
45 await e.onRendered.first; 46 await e.onRendered.first;
46 expect(e.children.length, isZero, reason: 'is empty'); 47 expect(e.children.length, isZero, reason: 'is empty');
47 }); 48 });
48 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698